From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-sn1nam02on0094.outbound.protection.outlook.com ([104.47.36.94]:48864 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726837AbeIXGy6 (ORCPT ); Mon, 24 Sep 2018 02:54:58 -0400 From: Sasha Levin To: Vinod CC: "stable@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Andy Shevchenko Subject: Re: [PATCH AUTOSEL 4.9 30/34] dmaengine: hsu: Support dmaengine_terminate_sync() Date: Mon, 24 Sep 2018 00:55:18 +0000 Message-ID: <20180924005514.GU3821@sasha-vm> References: <20180915013422.180023-1-alexander.levin@microsoft.com> <20180915013422.180023-30-alexander.levin@microsoft.com> <20180920003851.GA2350@vkoul-mobl> In-Reply-To: <20180920003851.GA2350@vkoul-mobl> Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-ID: <2282951F1B829545A91E8405DB2010CC@namprd21.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org List-ID: On Wed, Sep 19, 2018 at 05:38:51PM -0700, Vinod wrote: >On 15-09-18, 01:34, Sasha Levin wrote: >> From: Andy Shevchenko >> >> [ Upstream commit 2abc66cd499aa16876e45c6438788902f7d1ce22 ] >> >> It appears that the driver misses the support of dmaengine_terminate_syn= c(). >> Since many of callers expects this behaviour implement the new >> device_synchronize() callback to allow proper synchronization when stopp= ing >> a channel. > >This adds missing support for an optional call, but I am not aware of >any reports of breakage due to missing this patch. Do you want to carry >this for stable? I guess that using the word "expect" in the commit log suggested to me that this wasn't optional. I'll drop it, thanks!=