From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:58124 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728811AbeIYAnn (ORCPT ); Mon, 24 Sep 2018 20:43:43 -0400 Date: Mon, 24 Sep 2018 20:40:10 +0200 From: Greg Kroah-Hartman To: Joe Perches Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Bart Van Assche , Jason Gunthorpe , Sasha Levin Subject: Re: [PATCH 3.18 104/105] IB/nes: Fix a compiler warning Message-ID: <20180924184010.GC9122@kroah.com> References: <20180924113113.268650190@linuxfoundation.org> <20180924113123.002918395@linuxfoundation.org> <6f7ca3c205bada768c3918b1feacbbd5ce23a64d.camel@perches.com> <20180924175902.GB19402@kroah.com> <6d6f31c87b0c9b1a551d352439183c8c9c4df04c.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6d6f31c87b0c9b1a551d352439183c8c9c4df04c.camel@perches.com> Sender: stable-owner@vger.kernel.org List-ID: On Mon, Sep 24, 2018 at 11:03:25AM -0700, Joe Perches wrote: > On Mon, 2018-09-24 at 19:59 +0200, Greg Kroah-Hartman wrote: > > On Mon, Sep 24, 2018 at 09:38:26AM -0700, Joe Perches wrote: > > > On Mon, 2018-09-24 at 13:34 +0200, Greg Kroah-Hartman wrote: > > > > 3.18-stable review patch. If anyone has any objections, please let me know. > > > > > > Why should this sort of change be applied to a stable release? > > > > Originally I was just going to drop this as it's not fixing something. > > > > But it might be, if that macro is used in a if() statement, or something > > like that, it could be doing something unintended. > > No it couldn't. > An empty macro is equivalent to a single statement. {sigh} It's been a long few weeks... Yes, you are right, I was forgetting the trailing ; Ok, I'll go drop this now, thanks. greg k-h