From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:53032 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727201AbeIZSKk (ORCPT ); Wed, 26 Sep 2018 14:10:40 -0400 Date: Wed, 26 Sep 2018 13:57:58 +0200 From: Greg KH To: Daniel Borkmann Cc: ast@kernel.org, jannh@google.com, stable@vger.kernel.org Subject: Re: [PATCH stable 4.18] bpf/verifier: disallow pointer subtraction Message-ID: <20180926115758.GA22682@kroah.com> References: <93ead362151059fea0663734d55a9b4055eaaba7.1537881628.git.daniel@iogearbox.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <93ead362151059fea0663734d55a9b4055eaaba7.1537881628.git.daniel@iogearbox.net> Sender: stable-owner@vger.kernel.org List-ID: On Tue, Sep 25, 2018 at 03:25:18PM +0200, Daniel Borkmann wrote: > From: Alexei Starovoitov > > commit dd066823db2ac4e22f721ec85190817b58059a54 upstream. > > Subtraction of pointers was accidentally allowed for unpriv programs > by commit 82abbf8d2fc4. Revert that part of commit. > > Fixes: 82abbf8d2fc4 ("bpf: do not allow root to mangle valid pointers") > Reported-by: Jann Horn > Acked-by: Daniel Borkmann > Signed-off-by: Alexei Starovoitov > Signed-off-by: Daniel Borkmann > --- > kernel/bpf/verifier.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Now queued up, thanks. greg k-h