From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:51722 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728479AbeI1Ahs (ORCPT ); Thu, 27 Sep 2018 20:37:48 -0400 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w8RIEGN5087014 for ; Thu, 27 Sep 2018 14:18:17 -0400 Received: from e14.ny.us.ibm.com (e14.ny.us.ibm.com [129.33.205.204]) by mx0a-001b2d01.pphosted.com with ESMTP id 2ms2dn5ayk-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 27 Sep 2018 14:18:17 -0400 Received: from localhost by e14.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 27 Sep 2018 14:18:15 -0400 Date: Thu, 27 Sep 2018 11:18:06 -0700 From: "Paul E. McKenney" To: Mathieu Desnoyers Cc: shuah kh , rostedt , Thomas Gleixner , Shuah Khan , linux-kselftest , linux-kernel , linux-api , Peter Zijlstra , Boqun Feng , Andy Lutomirski , Dave Watson , Paul Turner , Andrew Morton , Russell King , Ingo Molnar , "H. Peter Anvin" , Andi Kleen , Chris Lameter , Ben Maurer , Josh Triplett , Linus Torvalds , Catalin Marinas , Will Deacon , Michael Kerrisk , Joel Fernandes , stable , shuah Subject: Re: [PATCH] rseq/selftests: fix parametrized test with -fpie Reply-To: paulmck@linux.ibm.com References: <20180918135328.32034-1-mathieu.desnoyers@efficios.com> <1367962117.10271.1537897176578.JavaMail.zimbra@efficios.com> <20180927092235.77282e35@vmware.local.home> <44897232.11546.1538071328396.JavaMail.zimbra@efficios.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <44897232.11546.1538071328396.JavaMail.zimbra@efficios.com> Message-Id: <20180927181806.GI4222@linux.ibm.com> Sender: stable-owner@vger.kernel.org List-ID: On Thu, Sep 27, 2018 at 02:02:08PM -0400, Mathieu Desnoyers wrote: > ----- On Sep 27, 2018, at 9:58 AM, Shuah Khan shuah.kh@samsung.com wrote: > > > On 09/27/2018 07:22 AM, Steven Rostedt wrote: > >> On Tue, 25 Sep 2018 13:39:36 -0400 (EDT) > >> Mathieu Desnoyers wrote: > >> > >>> ----- On Sep 18, 2018, at 9:53 AM, Mathieu Desnoyers > >>> mathieu.desnoyers@efficios.com wrote: > >>> > >>>> On x86-64, the parametrized selftest code for rseq crashes with a > >>>> segmentation fault when compiled with -fpie. This happens when the > >>>> param_test binary is loaded at an address beyond 32-bit on x86-64. > >>>> > >>>> The issue is caused by use of a 32-bit register to hold the address > >>>> of the loop counter variable. > >>>> > >>>> Fix this by using a 64-bit register to calculate the address of the > >>>> loop counter variables as an offset from rip. > >>> > >>> Should this fix go through tip or the selftests tree ? > >>> > >> > >> I usually have changes like this pulled through Shuah's tree with an > >> ack from the maintainer of the code that it tests. > >> > >> -- Steve > >> > > > > Right that is what I prefer. I usually wait for an Ack. I can pull this > > in. > > I am maintainer of the code that it tests as well, so being both author > of the selftest patch and giving an ack to it seems a bit silly. :) Other > rseq co-maintainers could weight in though: Peter, Paul, and Boqun. Here you go! ;-) Acked-by: Paul E. McKenney > Thanks, > > Mathieu > > > > > thanks, > > -- Shuah > > > > -- > > Shuah Khan > > Sr. Linux Kernel Developer > > Open Source Innovation Group > > Samsung Research America(Silicon Valley) > > shuah.kh@samsung.com > > -- > Mathieu Desnoyers > EfficiOS Inc. > http://www.efficios.com >