From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mail-eopbgr700125.outbound.protection.outlook.com ([40.107.70.125]:21824
        "EHLO NAM04-SN1-obe.outbound.protection.outlook.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1727393AbeI1CK0 (ORCPT <rfc822;stable@vger.kernel.org>);
        Thu, 27 Sep 2018 22:10:26 -0400
From: Sasha Levin <Alexander.Levin@microsoft.com>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
CC: "stable@vger.kernel.org" <stable@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH AUTOSEL 4.14 52/87] nfp: fail probe if serial or interface
 id is missing
Date: Thu, 27 Sep 2018 19:50:30 +0000
Message-ID: <20180927195028.GA69414@sasha-vm>
References: <20180917030220.245686-1-alexander.levin@microsoft.com>
 <20180917030220.245686-52-alexander.levin@microsoft.com>
 <20180917070317.19c09e88@cakuba.netronome.com>
In-Reply-To: <20180917070317.19c09e88@cakuba.netronome.com>
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <18D40E415E95FF47AAF6BCA2A2ABC7B6@namprd21.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Mon, Sep 17, 2018 at 07:03:17AM -0700, Jakub Kicinski wrote:
>On Mon, 17 Sep 2018 03:02:55 +0000, Sasha Levin wrote:
>> From: Jakub Kicinski <jakub.kicinski@netronome.com>
>>
>> [ Upstream commit 18aa5b180f00a10c2f63944b4f0ab116bf8ea19b ]
>>
>> On some platforms with broken ACPI tables we may not have access
>> to the Serial Number PCIe capability.  This capability is crucial
>> for us for switchdev operation as we use serial number as switch ID,
>> and for communication with management FW where interface ID is used.
>>
>> If we can't determine the Serial Number we have to fail device probe.
>>
>> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
>> Signed-off-by: David S. Miller <davem@davemloft.net>
>> Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
>
>If the problem occurs the driver would usually fail to probe anyway
>(e.g. due to missing SR-IOV capability), just without providing any
>clear message why.  So the patch is not of huge importance, but I'm
>not opposed to back porting it.
>
>I should've put this info in the commit message, my bad.

Now removed, thanks!=