From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-eopbgr700132.outbound.protection.outlook.com ([40.107.70.132]:30640 "EHLO NAM04-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727265AbeI1CMO (ORCPT ); Thu, 27 Sep 2018 22:12:14 -0400 From: Sasha Levin To: Ezequiel Garcia CC: "stable@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Hans Verkuil , Mauro Carvalho Chehab Subject: Re: [PATCH AUTOSEL 4.9 20/57] media: sta2x11: Add video_device and vb2_queue locks Date: Thu, 27 Sep 2018 19:52:18 +0000 Message-ID: <20180927195216.GB69414@sasha-vm> References: <20180917030340.378-1-alexander.levin@microsoft.com> <20180917030340.378-20-alexander.levin@microsoft.com> In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org List-ID: On Mon, Sep 17, 2018 at 08:50:27AM -0300, Ezequiel Garcia wrote: >Hi Sasha, > >On Mon, 2018-09-17 at 03:03 +0000, Sasha Levin wrote: >> From: Ezequiel Garcia >> >> [ Upstream commit cd63c0288fd760ce7de247fba618e2bbcfc0c35c ] >> >> Currently, this driver does not serialize its video4linux >> ioctls, which is a bug, as race conditions might appear. >> >> In addition, video_device and vb2_queue locks are now both >> mandatory. Add them, and implement wait_prepare and >> wait_finish. >> >> To stay on the safe side, this commit uses a single mutex >> for both locks. Better latency can be obtained by separating >> these if needed. >> >> Signed-off-by: Ezequiel Garcia >> Signed-off-by: Hans Verkuil >> Signed-off-by: Mauro Carvalho Chehab >> Signed-off-by: Sasha Levin > >Hm, I am not so sure this patch should go to -stable, >as it's not fixing a real bug we've seen out there. You don't really need to wait for a report of this happening if you're certain that this can happen in the "real world". Having a report is not a prerequisite of inclusion in stable. However, if you prefer not to, I can just remove it.=