From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:38257 "EHLO wout2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726106AbeI1LSj (ORCPT ); Fri, 28 Sep 2018 07:18:39 -0400 Date: Fri, 28 Sep 2018 06:56:45 +0200 From: Greg KH To: Chris Packham Cc: Luuk Paulussen , Jan Stancek , "stable@vger.kernel.org" , Herbert Xu Subject: Re: [linux main PATCH] crypto: qat - make qat_asym_algs.o depend on asn1 headers Message-ID: <20180928045645.GA21700@kroah.com> References: <20180927224244.24591-1-chris.packham@alliedtelesis.co.nz> <20180928044555.GB20540@kroah.com> <304152d5ecde432d97c93b211e50d0cf@svr-chch-ex1.atlnz.lc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <304152d5ecde432d97c93b211e50d0cf@svr-chch-ex1.atlnz.lc> Sender: stable-owner@vger.kernel.org List-ID: On Fri, Sep 28, 2018 at 04:51:43AM +0000, Chris Packham wrote: > Hi Greg, > > On 28/09/18 16:46, Greg KH wrote: > > On Fri, Sep 28, 2018 at 10:42:44AM +1200, Chris Packham wrote: > >> From: Jan Stancek > >> > >> Parallel build can sporadically fail because asn1 headers may > >> not be built yet by the time qat_asym_algs.o is compiled: > >> drivers/crypto/qat/qat_common/qat_asym_algs.c:55:32: fatal error: qat_rsapubkey-asn1.h: No such file or directory > >> #include "qat_rsapubkey-asn1.h" > >> > >> Cc: stable@vger.kernel.org > >> Signed-off-by: Jan Stancek > >> Signed-off-by: Herbert Xu > >> > >> [upstream commit 81dc0365cfa7bc7c08a0e44d9ee04964df782e19] > >> Reviewed-by: Scott Parlane > >> Reviewed-by: Luuk Paulussen > >> > >> Change-Id: Ie811cd1fbb497c84ca86d18ae8362973c600d9a1 > > > > Why is this change-id line here? What am I supposed to do with this > > patch overall? What stable tree do you want it in? It's already > > backported to really old kernels today, shouldn't you just be using them > > already? > > Sorry for the noise. I fat-fingered the git send-email invocation for > applying this to an internal kernel fork. Your internal kernel fork should be based on a newer kernel version. If you have to backport this old patch, you have much worse problems than this :) good luck! greg k-h