From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f196.google.com ([209.85.210.196]:33826 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728791AbeJAQqA (ORCPT ); Mon, 1 Oct 2018 12:46:00 -0400 Date: Mon, 1 Oct 2018 19:08:53 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Sergey Senozhatsky , LKML , Andrew Morton , stable@vger.kernel.org Subject: Re: [PATCH] zram: fix missing zero pages for memory tracking Message-ID: <20181001100853.GB578@jagdpanzerIV> References: <20180919051846.234615-1-minchan@kernel.org> <20180919072916.GA1180@jagdpanzerIV> <20180922031107.GA131541@rodete-laptop-imager.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180922031107.GA131541@rodete-laptop-imager.corp.google.com> Sender: stable-owner@vger.kernel.org List-ID: On (09/22/18 12:11), Minchan Kim wrote: > On Wed, Sep 19, 2018 at 04:29:16PM +0900, Sergey Senozhatsky wrote: > > On (09/19/18 14:18), Minchan Kim wrote: > > > We need to count zero filled pages as well as other pages in zram. > > > > A nit, > > > > 'ZRAM_FLAG_SHIFT + 1' covers all ZRAM_SAME pages, not only > > zero filled pages. > > I was brainfart. No, never :) And I totally didn't mean it. -ss