From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f65.google.com ([209.85.167.65]:35972 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729358AbeJAUE5 (ORCPT ); Mon, 1 Oct 2018 16:04:57 -0400 Received: by mail-lf1-f65.google.com with SMTP id d4-v6so89002lfa.3 for ; Mon, 01 Oct 2018 06:27:07 -0700 (PDT) Date: Mon, 1 Oct 2018 15:27:03 +0200 From: Niklas Cassel To: Bjorn Andersson Cc: Greg Kroah-Hartman , "Luis R. Rodriguez" , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, stable@vger.kernel.org, Rishabh Bhatnagar Subject: Re: [PATCH] firmware: Always initialize the fw_priv list object Message-ID: <20181001132703.GA12193@centauri.lan> References: <20180920010938.10315-1-bjorn.andersson@linaro.org> <20180920052204.GA15695@kroah.com> <20180920073415.GC1367@tuxbook-pro> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180920073415.GC1367@tuxbook-pro> Sender: stable-owner@vger.kernel.org List-ID: On Thu, Sep 20, 2018 at 12:34:15AM -0700, Bjorn Andersson wrote: > On Wed 19 Sep 22:22 PDT 2018, Greg Kroah-Hartman wrote: > > > On Wed, Sep 19, 2018 at 06:09:38PM -0700, Bjorn Andersson wrote: > > > When freeing the fw_priv the item is taken off the list. This causes an > > > oops in the FW_OPT_NOCACHE case as the list object is not initialized. > > > > > > Make sure to initialize the list object regardless of this flag. > > > > > > Fixes: 422b3db2a503 ("firmware: Fix security issue with request_firmware_into_buf()") > > > Cc: stable@vger.kernel.org > > > Cc: Rishabh Bhatnagar > > > Signed-off-by: Bjorn Andersson > > > --- > > > drivers/base/firmware_loader/main.c | 7 +++++-- > > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > Is this being triggered by some hardware somewhere today? Or is this > > just a fix found by code inspection? > > > > Hi Greg, > > Yes, I found this issue while attempting to load the firmware and boot > one of the DSPs on one of my Qualcomm dev boards after v4.19-rc4 and it > can be reproduced on the upstream Dragonboard 820c. I still see this issue on v4.19-rc6. It would be nice if this fix gets merged before v4.19 gets released. Kind regards, Niklas