From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Sasha Levin To: Daniel Wang CC: "rostedt@goodmis.org" , "stable@vger.kernel.org" , "pmladek@suse.com" , "akpm@linux-foundation.org" , "byungchul.park@lge.com" , "dave.hansen@intel.com" , "hannes@cmpxchg.org" , "jack@suse.cz" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "mathieu.desnoyers@efficios.com" , "mgorman@suse.de" , "mhocko@kernel.org" , "pavel@ucw.cz" , "penguin-kernel@i-love.sakura.ne.jp" , "peterz@infradead.org" , "tj@kernel.org" , "torvalds@linux-foundation.org" , "vbabka@suse.cz" , "xiyou.wangcong@gmail.com" , Peter Feiner Subject: Re: 4.14 backport request for dbdda842fe96f: "printk: Add console owner and waiter logic to load balance console writes" Date: Mon, 1 Oct 2018 20:40:24 +0000 Message-ID: <20181001204022.GE69414@sasha-vm> References: <20180927194601.207765-1-wonderfly@google.com> <20181001152324.72a20bea@gandalf.local.home> In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-ID: <748043772AB90F488DD1B400A54E69CC@namprd21.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: owner-linux-mm@kvack.org List-ID: On Mon, Oct 01, 2018 at 01:37:30PM -0700, Daniel Wang wrote: >On Mon, Oct 1, 2018 at 12:23 PM Steven Rostedt wrote= : >> >> > Serial console logs leading up to the deadlock. As can be seen the sta= ck trace >> > was incomplete because the printing path hit a timeout. >> >> I'm fine with having this backported. > >Thanks. I can send the cherrypicks your way. Do you recommend that I >include the three follow-up fixes though? > >c14376de3a1b printk: Wake klogd when passing console_lock owner >fd5f7cde1b85 printk: Never set console_may_schedule in console_trylock() >c162d5b4338d printk: Hide console waiter logic into helpers >dbdda842fe96 printk: Add console owner and waiter logic to load >balance console writes Maybe it'll also make sense to make the reproducer into a test that can go under tools/testing/ and we can backport that as well? It'll be helpful to have a way to make sure things are sane. -- Thanks, Sasha=