From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Zubin Mithra <zsm@chromium.org>,
stable@vger.kernel.org, Theodore Ts'o <tytso@mit.edu>,
stable@kernel.org
Subject: Re: [PATCH v4.9.y] ext4: never move the system.data xattr out of the inode body
Date: Tue, 2 Oct 2018 04:56:31 -0700 [thread overview]
Message-ID: <20181002115631.GC3030@kroah.com> (raw)
In-Reply-To: <1538327868-27369-1-git-send-email-linux@roeck-us.net>
On Sun, Sep 30, 2018 at 10:17:48AM -0700, Guenter Roeck wrote:
> From: Theodore Ts'o <tytso@mit.edu>
>
> commit 8cdb5240ec5928b20490a2bb34cb87e9a5f40226 upstream.
>
> When expanding the extra isize space, we must never move the
> system.data xattr out of the inode body. For performance reasons, it
> doesn't make any sense, and the inline data implementation assumes
> that system.data xattr is never in the external xattr block.
>
> This addresses CVE-2018-10880
>
> https://bugzilla.kernel.org/show_bug.cgi?id=200005
>
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> Cc: stable@kernel.org
> [groeck: Context changes]
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> I thought the 4.4.y backport should apply, but I think it doesn't after
> all. This backport applies to v4.9.y.
Thanks, that worked.
greg k-h
prev parent reply other threads:[~2018-10-02 18:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-30 17:17 [PATCH v4.9.y] ext4: never move the system.data xattr out of the inode body Guenter Roeck
2018-10-01 5:49 ` SZ Lin (林上智)
2018-10-02 11:56 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181002115631.GC3030@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux@roeck-us.net \
--cc=stable@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=zsm@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).