From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gwu.lbox.cz ([62.245.111.132]:35488 "EHLO gwu.lbox.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727188AbeJCQDJ (ORCPT ); Wed, 3 Oct 2018 12:03:09 -0400 Date: Wed, 3 Oct 2018 11:14:46 +0200 From: Nikola Ciprich To: Andy Lutomirski Cc: Greg KH , LKML , stable , Thomas Gleixner , Matt Rickard , Borislav Petkov , jason.vas.dias@gmail.com, David Woodhouse , Peter Zijlstra , Andi Kleen , Nikola Ciprich Subject: Re: [PATCH 4.14 114/165] x86/vdso: Fix vDSO build if a retpoline is emitted Message-ID: <20181003091446.GD31855@pcnci.linuxbox.cz> References: <20180903165655.003605184@linuxfoundation.org> <20180903165701.245301231@linuxfoundation.org> <20181002080655.GV31855@pcnci.linuxbox.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: stable-owner@vger.kernel.org List-ID: Hi Andy, yes, it indeed does fix the problem. Thanks! nik On Tue, Oct 02, 2018 at 09:27:21PM -0700, Andy Lutomirski wrote: > On Tue, Oct 2, 2018 at 1:21 AM Nikola Ciprich > wrote: > > > > Hi Greg and others, > > > > sorry for reporting this so late, but still... > > > > this breaks build on older compilers, since it requires > > -mindirect-branch=thunk-inline -mindirect-branch-register even though > > retpoline support is disabled in kernel config.. is this expected? > > > > Nope, my patch was buggy. Can you test the fix I just sent? > -- ------------------------------------- Ing. Nikola CIPRICH LinuxBox.cz, s.r.o. 28.rijna 168, 709 00 Ostrava tel.: +420 591 166 214 fax: +420 596 621 273 mobil: +420 777 093 799 www.linuxbox.cz mobil servis: +420 737 238 656 email servis: servis@linuxbox.cz -------------------------------------