From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mail.bootlin.com ([62.4.15.54]:47662 "EHLO mail.bootlin.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1728361AbeJEVi6 (ORCPT <rfc822;stable@vger.kernel.org>);
        Fri, 5 Oct 2018 17:38:58 -0400
Date: Fri, 5 Oct 2018 16:39:45 +0200
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Boris Brezillon <boris.brezillon@bootlin.com>,
        Richard Weinberger <richard@nod.at>,
        David Woodhouse <dwmw2@infradead.org>,
        Brian Norris <computersforpeace@gmail.com>,
        Marek Vasut <marek.vasut@gmail.com>
Cc: linux-mtd@lists.infradead.org, daniel@zonque.org,
        Chris.Packham@alliedtelesis.co.nz, stable@vger.kernel.org
Subject: Re: [PATCH] mtd: rawnand: marvell: fix the IRQ handler complete()
 condition
Message-ID: <20181005163945.7c00d565@xps13>
In-Reply-To: <20181003090504.19910-1-miquel.raynal@bootlin.com>
References: <20181003090504.19910-1-miquel.raynal@bootlin.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

Hello

Miquel Raynal <miquel.raynal@bootlin.com> wrote on Wed,  3 Oct 2018
11:05:04 +0200:

> With the current implementation, the complete() in the IRQ handler is
> supposed to be called only if the register status has one or the other
> RDY bit set. Other events might trigger an interrupt as well if
> enabled, but should not end-up with a complete() call.
> 
> For this purpose, the code was checking if the other bits were set, in
> this case complete() was not called. This is wrong as two events might
> happen in a very tight time-frame and if the NDSR status read reports
> two bits set (eg. RDY(0) and RDDREQ) at the same time, complete() was
> not called.
> 
> This logic would lead to timeouts in marvell_nfc_wait_op() and has
> been observed on PXA boards (NFCv1) in the Hamming write path.
> 
> Fixes: 02f26ecf8c77 ("mtd: nand: add reworked Marvell NAND controller driver")
> Cc: stable@vger.kernel.org
> Reported-by: Daniel Mack <daniel@zonque.org>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> Tested-by: Daniel Mack <daniel@zonque.org>
> ---
>  drivers/mtd/nand/raw/marvell_nand.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/raw/marvell_nand.c b/drivers/mtd/nand/raw/marvell_nand.c
> index bc2ef5209783..c7573ccdbacd 100644
> --- a/drivers/mtd/nand/raw/marvell_nand.c
> +++ b/drivers/mtd/nand/raw/marvell_nand.c
> @@ -686,7 +686,7 @@ static irqreturn_t marvell_nfc_isr(int irq, void *dev_id)
>  
>  	marvell_nfc_disable_int(nfc, st & NDCR_ALL_INT);
>  
> -	if (!(st & (NDSR_RDDREQ | NDSR_WRDREQ | NDSR_WRCMDREQ)))
> +	if (st & (NDSR_RDY(0) | NDSR_RDY(1)))
>  		complete(&nfc->complete);
>  
>  	return IRQ_HANDLED;

Applied to nand/next.