RE: [PATCH 3/5] Drivers: hv: kvp: Fix the recent regression caused by incorrect clean-up

Dexuan Cui
2018-10-17T18:01:15Z

> From: devel <driverdev-devel-bounces@linuxdriverproject.org> On Behalf Of
> Greg KH
> Sent: Tuesday, October 16, 2018 22:07
> > ...
> > + case KVP_OP_GET:
> > + message->body.kvp_get.data.key_size =
> > + utf16s_to_utf8s(
> > + (wchar_t *)in_msg->body.kvp_get.data.key,
> > + in_msg->body.kvp_get.data.key_size,
> > + UTF16_LITTLE_ENDIAN,
> > + message->body.kvp_get.data.key,
> > + HV_KVP_EXCHANGE_MAX_KEY_SIZE - 1) + 1;
>
> Worst indentation ever :(
>
> Yeah, I know it follows the others above it, but you should reconsider
> it in the future...
> greg k-h

Agreed. We should consider improving this in future.

-- Dexuan