From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.bootlin.com ([62.4.15.54]:51503 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728216AbeJVWQv (ORCPT ); Mon, 22 Oct 2018 18:16:51 -0400 Date: Mon, 22 Oct 2018 15:57:57 +0200 From: Alexandre Belloni To: Soeren Moch Cc: stable@vger.kernel.org, Andrea Greco , Alessandro Zummo , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rtc: ds1307: fix ds1339 wakealarm support Message-ID: <20181022135757.GQ17341@piout.net> References: <20181022123812.5782-1-smoch@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181022123812.5782-1-smoch@web.de> Sender: stable-owner@vger.kernel.org List-ID: Hello, On 22/10/2018 14:38:12+0200, Soeren Moch wrote: > Commit 51ed73eb998a1c79a2b0e9bed68f75a8a2c93b9b ("rtc: ds1340: Add support > for trickle charger.") breaks ds1339 wakealarm support by limiting > accessible registers. Fix this. > > Fixes: 51ed73eb998a ("rtc: ds1340: Add support for trickle charger.") > Cc: stable@vger.kernel.org > Signed-off-by: Soeren Moch > -- > Cc: Andrea Greco > Cc: Alessandro Zummo > Cc: Alexandre Belloni > Cc: linux-rtc@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- > drivers/rtc/rtc-ds1307.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c > index 4b2b4627daeb..71396b62dc52 100644 > --- a/drivers/rtc/rtc-ds1307.c > +++ b/drivers/rtc/rtc-ds1307.c > @@ -1384,7 +1384,6 @@ static void ds1307_clks_register(struct ds1307 *ds1307) > static const struct regmap_config regmap_config = { > .reg_bits = 8, > .val_bits = 8, > - .max_register = 0x9, I would prefer having a different regmap_config for chips that have more registers. I guess you could put a pointer to a regmap_config in chip_desc. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com