From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f53.google.com ([209.85.221.53]:34435 "EHLO mail-wr1-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728599AbeJWSH1 (ORCPT ); Tue, 23 Oct 2018 14:07:27 -0400 Received: by mail-wr1-f53.google.com with SMTP id l6-v6so937916wrt.1 for ; Tue, 23 Oct 2018 02:44:48 -0700 (PDT) Date: Tue, 23 Oct 2018 10:44:45 +0100 From: Sudip Mukherjee To: Greg Kroah-Hartman Cc: stable@vger.kernel.org, Colin Ian King , Chris Wilson , Zhenyu Wang Subject: request for 4.14-stable: ffdf16edfbbe ("drm/i915/gvt: fix memory leak of a cmd_entry struct on error exit path") Message-ID: <20181023094445.mjeeogd7hwlbpglr@debian> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="c7prgrozipsjtzhd" Content-Disposition: inline Sender: stable-owner@vger.kernel.org List-ID: --c7prgrozipsjtzhd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Greg, This was not marked for stable but seems it should be in stable. Please apply to your queue of 4.14-stable. -- Regards Sudip --c7prgrozipsjtzhd Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-drm-i915-gvt-fix-memory-leak-of-a-cmd_entry-struct-o.patch" >>From 2f98e9fe07c5ed6a36646f71e7eb5486ca17db3e Mon Sep 17 00:00:00 2001 From: Colin Ian King Date: Tue, 10 Apr 2018 13:33:12 +0100 Subject: [PATCH] drm/i915/gvt: fix memory leak of a cmd_entry struct on error exit path commit ffdf16edfbbe77f5f5c3c87fe8d7387ecd16241b upstream The error exit path when a duplicate is found does not kfree and cmd_entry struct and hence there is a small memory leak. Fix this by kfree'ing it. Detected by CoverityScan, CID#1370198 ("Resource Leak") Fixes: be1da7070aea ("drm/i915/gvt: vGPU command scanner") Signed-off-by: Colin Ian King Reviewed-by: Chris Wilson Signed-off-by: Zhenyu Wang Signed-off-by: Sudip Mukherjee --- drivers/gpu/drm/i915/gvt/cmd_parser.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/gvt/cmd_parser.c b/drivers/gpu/drm/i915/gvt/cmd_parser.c index d4726a3358a4..d6993c2707d1 100644 --- a/drivers/gpu/drm/i915/gvt/cmd_parser.c +++ b/drivers/gpu/drm/i915/gvt/cmd_parser.c @@ -2802,6 +2802,7 @@ static int init_cmd_table(struct intel_gvt *gvt) if (info) { gvt_err("%s %s duplicated\n", e->info->name, info->name); + kfree(e); return -EEXIST; } -- 2.11.0 --c7prgrozipsjtzhd--