From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-f66.google.com ([209.85.208.66]:44045 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726970AbeJWWFh (ORCPT ); Tue, 23 Oct 2018 18:05:37 -0400 Received: by mail-ed1-f66.google.com with SMTP id z21-v6so1650918edb.11 for ; Tue, 23 Oct 2018 06:42:06 -0700 (PDT) Date: Tue, 23 Oct 2018 15:42:02 +0200 From: Daniel Vetter To: Eugeniy Paltsev Cc: "dri-devel@lists.freedesktop.org" , "airlied@linux.ie" , "linux-kernel@vger.kernel.org" , "daniel.vetter@ffwll.ch" , "linux-snps-arc@lists.infradead.org" , "stable@vger.kernel.org" , "marcheu@chromium.org" , Alexey Brodkin , "maarten.lankhorst@linux.intel.com" , "gustavo@padovan.org" , "sean@poorly.run" Subject: Re: [PATCH] DRM: UDL: get rid of useless vblank initialization Message-ID: <20181023134202.GP324@phenom.ffwll.local> References: <20180928144126.21598-1-Eugeniy.Paltsev@synopsys.com> <1540292472.19916.13.camel@synopsys.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1540292472.19916.13.camel@synopsys.com> Sender: stable-owner@vger.kernel.org List-ID: On Tue, Oct 23, 2018 at 11:01:14AM +0000, Eugeniy Paltsev wrote: > Hi David, > > Maybe you have any comments or remarks about this patch? > And if you don't could you please apply it. Thanks! Hm I hoped Sean would pick this up. I stuffed it into drm-misc-next now, and Sean owes me one. Generally pinging Dave is a last resort in dri-devel (and doesn't work too well). Thanks for your patch. -Daniel > > On Fri, 2018-09-28 at 17:41 +0300, Eugeniy Paltsev wrote: > > UDL doesn't support vblank functionality so we don't need to > > initialize vblank here (we are able to send page flip > > completion events even without vblank initialization) > > > > Moreover current drm_vblank_init call with num_crtcs > 0 causes > > sending DRM_EVENT_FLIP_COMPLETE event with zero timestamp every > > time. This breaks userspace apps (for example weston) which > > relies on timestamp value. > > > > Reviewed-by: Daniel Vetter > > Cc: stable@vger.kernel.org > > Signed-off-by: Eugeniy Paltsev > > --- > > drivers/gpu/drm/udl/udl_main.c | 7 +------ > > 1 file changed, 1 insertion(+), 6 deletions(-) > > > > diff --git a/drivers/gpu/drm/udl/udl_main.c b/drivers/gpu/drm/udl/udl_main.c > > index f455f095a146..1b014d92855b 100644 > > --- a/drivers/gpu/drm/udl/udl_main.c > > +++ b/drivers/gpu/drm/udl/udl_main.c > > @@ -350,15 +350,10 @@ int udl_driver_load(struct drm_device *dev, unsigned long flags) > > if (ret) > > goto err; > > > > - ret = drm_vblank_init(dev, 1); > > - if (ret) > > - goto err_fb; > > - > > drm_kms_helper_poll_init(dev); > > > > return 0; > > -err_fb: > > - udl_fbdev_cleanup(dev); > > + > > err: > > if (udl->urbs.count) > > udl_free_urb_list(dev); > -- > Eugeniy Paltsev -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch