From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:40854 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727437AbeJXANI (ORCPT ); Tue, 23 Oct 2018 20:13:08 -0400 Date: Tue, 23 Oct 2018 11:49:08 -0400 From: Sasha Levin To: Dmitry Torokhov Cc: stable@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH AUTOSEL 4.18 08/27] Input: evdev - add a schedule point in evdev_write() Message-ID: <20181023154908.GB24189@sasha-vm> References: <20181022101924.40531-1-sashal@kernel.org> <20181022101924.40531-8-sashal@kernel.org> <20181022170244.GB27929@dtor-ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20181022170244.GB27929@dtor-ws> Sender: stable-owner@vger.kernel.org List-ID: On Mon, Oct 22, 2018 at 10:02:44AM -0700, Dmitry Torokhov wrote: >Hi Sasha, > >On Mon, Oct 22, 2018 at 06:19:05AM -0400, Sasha Levin wrote: >> From: Dmitry Torokhov >> >> [ Upstream commit 36d2582ff235b4e01ad64a734c877a52dc762d9c ] >> >> Large writes to evdev interface may cause rcu stalls. Let's add >> cond_resched() to the loop to avoid this. > >This is not needed in stable: > >- the interfaces are not accessible for unprivileged users so there is > no DOS concerns >- the issue can only happen on non-preemptible kernels >- the issue only showed up with synthetic test and not real life use > cases >- this is not a regression > >The same goes to similar patches to mousedev, joydev and uinput that you >autoselected. Dropped, thanks! -- Thanks, Sasha