Re: [PATCH AUTOSEL 3.18 04/98] USB: qcserial: Fix support for HP lt4112 LTE/HSPA+ Gobi 4G Modem

Johan Hovold
2018-10-26T09:11:27Z

On Fri, Oct 26, 2018 at 11:02:24AM +0200, Bjï¿½rn Mork wrote:
> Johan Hovold <johan@kernel.org> writes:
>
> > Note that the stable tag above lacks a version comment (e.g. "# 4.19"),
> > but I can see how that may be too subtle to convey this (and not all
> > maintainers use those). Perhaps an explicit comment should just be added
> > in such cases.
>
> I have always thought that the inclusion of a "Fixes" tag made such
> comments redundant. A simple "git tag --contains .." returns the same
> info, and is more likely to be correct...
>
> Or am I missing something?

No, you're right. I also assume a Fixes tag to be sufficient these days
and any version comment to be more of a hint for humans.

> I see the problem with matching up fixes to backported commits, but I've
> assumed the stable maintainers all keep a small "database" of backported
> commits to make such tasks easier. That's what I would have done, and
> they are much smarter than me ;-)

Indeed, and that would also catch things like dependencies and other
commits that eventually end up in the stable trees. This could also be
automated based on the

commit 59536da34513c594af2a6fd35ba65ea45b6960a1 upstream

that gets added to the commit message during backporting.

Thanks,
Johan