From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:36166 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726275AbeJZTc6 (ORCPT ); Fri, 26 Oct 2018 15:32:58 -0400 Date: Fri, 26 Oct 2018 06:56:20 -0400 From: Sasha Levin To: Pavel Machek Cc: stable@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Drake , Dmitry Torokhov Subject: Re: [PATCH AUTOSEL 4.14 03/15] Input: i8042 - enable keyboard wakeups by default when s2idle is used Message-ID: <20181026105620.GC2015@sasha-vm> References: <20181022102026.40869-1-sashal@kernel.org> <20181022102026.40869-3-sashal@kernel.org> <20181026090452.GB20200@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20181026090452.GB20200@amd> Sender: stable-owner@vger.kernel.org List-ID: On Fri, Oct 26, 2018 at 11:04:52AM +0200, Pavel Machek wrote: >On Mon 2018-10-22 06:20:14, Sasha Levin wrote: >> From: Daniel Drake >> >> [ Upstream commit 684bec1092b6991ff2a7751e8a763898576eb5c2 ] >> >> Previously, on typical consumer laptops, pressing a key on the keyboard >> when the system is in suspend would cause it to wake up (default or >> unconditional behaviour). This happens because the EC generates a SCI >> interrupt in this scenario. >> >> That is no longer true on modern laptops based on Intel WhiskeyLake, >> including Acer Swift SF314-55G, Asus UX333FA, Asus UX433FN and Asus >> UX533FD. We confirmed with Asus EC engineers that the "Modern Standby" >> design has been modified so that the EC no longer generates a SCI >> in this case; the keyboard controller itself should be used for wakeup. >> >> In order to retain the standard behaviour of being able to use the >> keyboard to wake up the system, enable serio wakeups by default on >> platforms that are using s2idle. > >Behaviour change, not a bugfix. Someone may like their laptop sleeping >after keypress, we should not change it in the middle of -stable >series. Dmitry already asked for it to be dropped, so it's gone. -- Thanks, Sasha