* [PATCH] Blacklist SAMSUNG MZ7TD256HAFV-000L9 SSD
@ 2018-10-28 14:34 Diego Viola
2018-10-28 15:08 ` Hans de Goede
2018-11-09 11:16 ` Diego Viola
0 siblings, 2 replies; 3+ messages in thread
From: Diego Viola @ 2018-10-28 14:34 UTC (permalink / raw)
To: hdegoede; +Cc: axboe, tj, linux-kernel, stable, Diego Viola
med_power_with_dipm still causes freezes after updating the firmware to
the latest version (DXT04L5Q).
Set model_rev to NULL and blacklist the device.
Signed-off-by: Diego Viola <diego.viola@gmail.com>
---
drivers/ata/libata-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 6e594644cb1d..a7f5202a4815 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -4553,7 +4553,7 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
/* These specific Samsung models/firmware-revs do not handle LPM well */
{ "SAMSUNG MZMPC128HBFU-000MV", "CXM14M1Q", ATA_HORKAGE_NOLPM, },
{ "SAMSUNG SSD PM830 mSATA *", "CXM13D1Q", ATA_HORKAGE_NOLPM, },
- { "SAMSUNG MZ7TD256HAFV-000L9", "DXT02L5Q", ATA_HORKAGE_NOLPM, },
+ { "SAMSUNG MZ7TD256HAFV-000L9", NULL, ATA_HORKAGE_NOLPM, },
/* devices that don't properly handle queued TRIM commands */
{ "Micron_M500IT_*", "MU01", ATA_HORKAGE_NO_NCQ_TRIM |
--
2.19.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Blacklist SAMSUNG MZ7TD256HAFV-000L9 SSD
2018-10-28 14:34 [PATCH] Blacklist SAMSUNG MZ7TD256HAFV-000L9 SSD Diego Viola
@ 2018-10-28 15:08 ` Hans de Goede
2018-11-09 11:16 ` Diego Viola
1 sibling, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2018-10-28 15:08 UTC (permalink / raw)
To: Diego Viola; +Cc: axboe, tj, linux-kernel, stable
Hi,
On 28-10-18 15:34, Diego Viola wrote:
> med_power_with_dipm still causes freezes after updating the firmware to
> the latest version (DXT04L5Q).
>
> Set model_rev to NULL and blacklist the device.
>
> Signed-off-by: Diego Viola <diego.viola@gmail.com>
Thank you for the patch.
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/ata/libata-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 6e594644cb1d..a7f5202a4815 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -4553,7 +4553,7 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
> /* These specific Samsung models/firmware-revs do not handle LPM well */
> { "SAMSUNG MZMPC128HBFU-000MV", "CXM14M1Q", ATA_HORKAGE_NOLPM, },
> { "SAMSUNG SSD PM830 mSATA *", "CXM13D1Q", ATA_HORKAGE_NOLPM, },
> - { "SAMSUNG MZ7TD256HAFV-000L9", "DXT02L5Q", ATA_HORKAGE_NOLPM, },
> + { "SAMSUNG MZ7TD256HAFV-000L9", NULL, ATA_HORKAGE_NOLPM, },
>
> /* devices that don't properly handle queued TRIM commands */
> { "Micron_M500IT_*", "MU01", ATA_HORKAGE_NO_NCQ_TRIM |
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Blacklist SAMSUNG MZ7TD256HAFV-000L9 SSD
2018-10-28 14:34 [PATCH] Blacklist SAMSUNG MZ7TD256HAFV-000L9 SSD Diego Viola
2018-10-28 15:08 ` Hans de Goede
@ 2018-11-09 11:16 ` Diego Viola
1 sibling, 0 replies; 3+ messages in thread
From: Diego Viola @ 2018-11-09 11:16 UTC (permalink / raw)
To: axboe; +Cc: hdegoede, tj, linux-kernel, stable
On Sun, Oct 28, 2018 at 11:34 AM Diego Viola <diego.viola@gmail.com> wrote:
>
> med_power_with_dipm still causes freezes after updating the firmware to
> the latest version (DXT04L5Q).
>
> Set model_rev to NULL and blacklist the device.
>
> Signed-off-by: Diego Viola <diego.viola@gmail.com>
> ---
> drivers/ata/libata-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 6e594644cb1d..a7f5202a4815 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -4553,7 +4553,7 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
> /* These specific Samsung models/firmware-revs do not handle LPM well */
> { "SAMSUNG MZMPC128HBFU-000MV", "CXM14M1Q", ATA_HORKAGE_NOLPM, },
> { "SAMSUNG SSD PM830 mSATA *", "CXM13D1Q", ATA_HORKAGE_NOLPM, },
> - { "SAMSUNG MZ7TD256HAFV-000L9", "DXT02L5Q", ATA_HORKAGE_NOLPM, },
> + { "SAMSUNG MZ7TD256HAFV-000L9", NULL, ATA_HORKAGE_NOLPM, },
>
> /* devices that don't properly handle queued TRIM commands */
> { "Micron_M500IT_*", "MU01", ATA_HORKAGE_NO_NCQ_TRIM |
> --
> 2.19.1
>
Hi Jens,
When do you plan to merge my patch?
Do you have any objections?
Thanks,
Diego
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-09 20:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-28 14:34 [PATCH] Blacklist SAMSUNG MZ7TD256HAFV-000L9 SSD Diego Viola
2018-10-28 15:08 ` Hans de Goede
2018-11-09 11:16 ` Diego Viola
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox