From: Ming Lei <ming.lei@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Ming Lei <ming.lei@redhat.com>,
Rui Salvaterra <rsalvaterra@gmail.com>,
stable@vger.kernel.org, Mike Snitzer <snitzer@redhat.com>,
Christoph Hellwig <hch@lst.de>, Xiao Ni <xni@redhat.com>,
Mariusz Dabrowski <mariusz.dabrowski@intel.com>
Subject: [PATCH V2 3/3] block: make sure writesame bio is aligned with logical block size
Date: Mon, 29 Oct 2018 20:57:19 +0800 [thread overview]
Message-ID: <20181029125719.4998-4-ming.lei@redhat.com> (raw)
In-Reply-To: <20181029125719.4998-1-ming.lei@redhat.com>
Obviously the created writesame bio has to be aligned with logical block
size, and use bio_allowed_max_sectors() to retrieve this number.
Fixes: b49a0871be31a745b2ef ("block: remove split code in blkdev_issue_{discard,write_same}")
Cc: Rui Salvaterra <rsalvaterra@gmail.com>
Cc: stable@vger.kernel.org
Cc: Mike Snitzer <snitzer@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Xiao Ni <xni@redhat.com>
Cc: Mariusz Dabrowski <mariusz.dabrowski@intel.com>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
block/blk-lib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/blk-lib.c b/block/blk-lib.c
index d58d5d87dd88..e8b3bb9bf375 100644
--- a/block/blk-lib.c
+++ b/block/blk-lib.c
@@ -149,7 +149,7 @@ static int __blkdev_issue_write_same(struct block_device *bdev, sector_t sector,
return -EOPNOTSUPP;
/* Ensure that max_write_same_sectors doesn't overflow bi_size */
- max_write_same_sectors = UINT_MAX >> 9;
+ max_write_same_sectors = bio_allowed_max_sectors(q);
while (nr_sects) {
bio = blk_next_bio(bio, 1, gfp_mask);
--
2.9.5
next prev parent reply other threads:[~2018-10-29 21:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-29 12:57 [PATCH V2 0/3] block: make sure discard/writesame bio is aligned with logical block size Ming Lei
2018-10-29 12:57 ` [PATCH V2 1/3] block: make sure discard " Ming Lei
2018-10-29 12:57 ` Ming Lei [this message]
2018-11-05 3:41 ` [PATCH V2 0/3] block: make sure discard/writesame " Ming Lei
2018-11-06 16:48 ` Rui Salvaterra
2018-11-07 0:55 ` Ming Lei
2018-11-09 13:24 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181029125719.4998-4-ming.lei@redhat.com \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=mariusz.dabrowski@intel.com \
--cc=rsalvaterra@gmail.com \
--cc=snitzer@redhat.com \
--cc=stable@vger.kernel.org \
--cc=xni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox