From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:40302 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725915AbeJ2WZT (ORCPT ); Mon, 29 Oct 2018 18:25:19 -0400 Date: Mon, 29 Oct 2018 09:36:35 -0400 From: Sasha Levin To: Arnd Bergmann Cc: Paul Burton , "stable@vger.kernel.org" , "linux-kernel@vger.kernel.org" , James Hogan , Ralf Baechle , "linux-mips@linux-mips.org" Subject: Re: [PATCH AUTOSEL 4.14 33/46] MIPS: Workaround GCC __builtin_unreachable reordering bug Message-ID: <20181029133635.GM2015@sasha-vm> References: <20181025141053.213330-1-sashal@kernel.org> <20181025141053.213330-33-sashal@kernel.org> <20181025195254.q55noj2rdh5vyw5s@pburton-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: Sender: stable-owner@vger.kernel.org List-ID: On Fri, Oct 26, 2018 at 09:36:30AM +0200, Arnd Bergmann wrote: >On 10/25/18, Paul Burton wrote: >> On Thu, Oct 25, 2018 at 10:10:40AM -0400, Sasha Levin wrote: >>> From: Paul Burton >>> --- >>> arch/mips/Kconfig | 1 + >>> arch/mips/include/asm/compiler.h | 35 ++++++++++++++++++++++++++++++++ >>> 2 files changed, 36 insertions(+) >> >> In principle I'm fine with backporting this - it does fix broken builds. >> >> It's only going to be of any use though if you also backport commit >> 04f264d3a8b0 ("compiler.h: Allow arch-specific asm/compiler.h"). I'd >> recommend backporting both or neither. >> >> In practice I think it's unlikely anyone will need a microMIPS kernel & >> be tied to the particular versions affected by the bug this patch fixed, >> so I don't think it's a problem to backport neither. > >I think the current practice of the stable kernel these days is to take >both patches in this case: They fix an actual bug in the mainline kernel, >and it seems unlikely enough that they cause a regression if backported, >so putting them into 4.14 has more advantages than disadvantages. I'll take both, thank you! -- Thanks, Sasha