From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:37884 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729492AbeJaX0C (ORCPT ); Wed, 31 Oct 2018 19:26:02 -0400 Date: Wed, 31 Oct 2018 10:27:45 -0400 From: Sasha Levin To: Adrian Bunk Cc: stable@vger.kernel.org, Alan Chiang , Andy Yeh , Bartosz Golaszewski , linux-i2c@vger.kernel.org Subject: Re: 4.14/4.18: Please add "eeprom: at24: Add support for address-width property" Message-ID: <20181031142745.GK194472@sasha-vm> References: <20181022083835.GA5315@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20181022083835.GA5315@localhost> Sender: stable-owner@vger.kernel.org List-ID: On Mon, Oct 22, 2018 at 11:38:35AM +0300, Adrian Bunk wrote: >Please cherry-pick the following commit to 4.14 and 4.18: > > commit a2b3bf4846e5eed62ea6abb096af2c950961033c > Author: Alan Chiang > Date: Wed Jul 25 11:20:22 2018 +0800 > > eeprom: at24: Add support for address-width property > > Provide a flexible way to determine the addressing bits of eeprom. > Pass the addressing bits to driver through address-width property. > > Signed-off-by: Alan Chiang > Signed-off-by: Andy Yeh > Signed-off-by: Bartosz Golaszewski > > >Confirmed to work on 4.14 with the Identification Page >of an ST M24M02-DR (256 bytes but 16 bit addressing). This patch doesn't look like stable material. The hardware never worked before, so this is not a regression and falls under new hardware enablement, but the patch is more complex than what we usually allow for hardware enablement (adding various IDs/quirks/etc). Am I missing something? -- Thanks, Sasha