From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=fHbq=NM=bootlin.com=alexandre.belloni@kernel.org>
Date: Thu, 1 Nov 2018 01:27:08 +0100
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Sasha Levin <sashal@kernel.org>
Cc: stable@vger.kernel.org, linux-kernel@vger.kernel.org,
	Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH AUTOSEL 3.18 22/22] mfd: menelaus: Fix possible race
 condition and leak
Message-ID: <20181101002708.GG24212@piout.net>
References: <20181031231206.29509-1-sashal@kernel.org>
 <20181031231206.29509-22-sashal@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20181031231206.29509-22-sashal@kernel.org>
List-ID: <stable.vger.kernel.org>

Hello,

On 31/10/2018 19:12:06-0400, Sasha Levin wrote:
> -	m->rtc = rtc_device_register(DRIVER_NAME,
> -			&m->client->dev,
> -			&menelaus_rtc_ops, THIS_MODULE);
> -	if (IS_ERR(m->rtc)) {
> +	err = rtc_register_device(m->rtc);

This appeared in v4.13, this will not compile on v3.18.

> +	if (err) {
>  		if (alarm) {
>  			menelaus_remove_irq_work(MENELAUS_RTCALM_IRQ);
>  			device_init_wakeup(&m->client->dev, 0);
> -- 
> 2.17.1
> 

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com