From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mail.kernel.org ([198.145.29.99]:53200 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1725978AbeKAKaW (ORCPT <rfc822;stable@vger.kernel.org>);
        Thu, 1 Nov 2018 06:30:22 -0400
Date: Wed, 31 Oct 2018 21:29:36 -0400
From: Sasha Levin <sashal@kernel.org>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: stable@vger.kernel.org, linux-kernel@vger.kernel.org,
        Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH AUTOSEL 3.18 22/22] mfd: menelaus: Fix possible race
 condition and leak
Message-ID: <20181101012936.GY194472@sasha-vm>
References: <20181031231206.29509-1-sashal@kernel.org>
 <20181031231206.29509-22-sashal@kernel.org>
 <20181101002708.GG24212@piout.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <20181101002708.GG24212@piout.net>
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Thu, Nov 01, 2018 at 01:27:08AM +0100, Alexandre Belloni wrote:
>Hello,
>
>On 31/10/2018 19:12:06-0400, Sasha Levin wrote:
>> -	m->rtc = rtc_device_register(DRIVER_NAME,
>> -			&m->client->dev,
>> -			&menelaus_rtc_ops, THIS_MODULE);
>> -	if (IS_ERR(m->rtc)) {
>> +	err = rtc_register_device(m->rtc);
>
>This appeared in v4.13, this will not compile on v3.18.

Indeed, I guess I need more cross-compilers here. Thanks!

--
Thanks,
Sasha