From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Dengcheng Zhu <dzhu@wavecomp.com>,
Paul Burton <paul.burton@mips.com>,
pburton@wavecomp.com, ralf@linux-mips.org,
linux-mips@linux-mips.org, rachel.mozes@intel.com,
Sasha Levin <sashal@kernel.org>
Subject: [PATCH AUTOSEL 4.4 10/15] MIPS: kexec: Mark CPU offline before disabling local IRQ
Date: Sun, 4 Nov 2018 08:54:12 -0500 [thread overview]
Message-ID: <20181104135417.88671-10-sashal@kernel.org> (raw)
In-Reply-To: <20181104135417.88671-1-sashal@kernel.org>
From: Dengcheng Zhu <dzhu@wavecomp.com>
[ Upstream commit dc57aaf95a516f70e2d527d8287a0332c481a226 ]
After changing CPU online status, it will not be sent any IPIs such as in
__flush_cache_all() on software coherency systems. Do this before disabling
local IRQ.
Signed-off-by: Dengcheng Zhu <dzhu@wavecomp.com>
Signed-off-by: Paul Burton <paul.burton@mips.com>
Patchwork: https://patchwork.linux-mips.org/patch/20571/
Cc: pburton@wavecomp.com
Cc: ralf@linux-mips.org
Cc: linux-mips@linux-mips.org
Cc: rachel.mozes@intel.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
arch/mips/kernel/crash.c | 3 +++
arch/mips/kernel/machine_kexec.c | 3 +++
2 files changed, 6 insertions(+)
diff --git a/arch/mips/kernel/crash.c b/arch/mips/kernel/crash.c
index 610f0f3bdb34..93c46c9cebb7 100644
--- a/arch/mips/kernel/crash.c
+++ b/arch/mips/kernel/crash.c
@@ -34,6 +34,9 @@ static void crash_shutdown_secondary(void *passed_regs)
if (!cpu_online(cpu))
return;
+ /* We won't be sent IPIs any more. */
+ set_cpu_online(cpu, false);
+
local_irq_disable();
if (!cpumask_test_cpu(cpu, &cpus_in_crash))
crash_save_cpu(regs, cpu);
diff --git a/arch/mips/kernel/machine_kexec.c b/arch/mips/kernel/machine_kexec.c
index 50980bf3983e..92bc066e47a3 100644
--- a/arch/mips/kernel/machine_kexec.c
+++ b/arch/mips/kernel/machine_kexec.c
@@ -95,6 +95,9 @@ machine_kexec(struct kimage *image)
*ptr = (unsigned long) phys_to_virt(*ptr);
}
+ /* Mark offline BEFORE disabling local irq. */
+ set_cpu_online(smp_processor_id(), false);
+
/*
* we do not want to be bothered.
*/
--
2.17.1
next prev parent reply other threads:[~2018-11-04 23:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-04 13:54 [PATCH AUTOSEL 4.4 01/15] mm/vmstat.c: assert that vmstat_text is in sync with stat_items_size Sasha Levin
2018-11-04 13:54 ` [PATCH AUTOSEL 4.4 02/15] mm: don't warn about large allocations for slab Sasha Levin
2018-11-04 13:54 ` [PATCH AUTOSEL 4.4 03/15] tty: check name length in tty_find_polling_driver() Sasha Levin
2018-11-04 13:54 ` [PATCH AUTOSEL 4.4 04/15] powerpc/nohash: fix undefined behaviour when testing page size support Sasha Levin
2018-11-04 13:54 ` [PATCH AUTOSEL 4.4 05/15] watchdog: lantiq: update register names to better match spec Sasha Levin
2018-11-04 13:54 ` [PATCH AUTOSEL 4.4 06/15] drm/omap: fix memory barrier bug in DMM driver Sasha Levin
2018-11-04 13:54 ` [PATCH AUTOSEL 4.4 07/15] iio: adc: at91: fix wrong channel number in triggered buffer mode Sasha Levin
2018-11-04 13:54 ` [PATCH AUTOSEL 4.4 08/15] iio: adc: at91: fix acking DRDY irq on simple conversions Sasha Levin
2018-11-04 13:54 ` [PATCH AUTOSEL 4.4 09/15] media: pci: cx23885: handle adding to list failure Sasha Levin
2018-11-04 13:54 ` Sasha Levin [this message]
2018-11-04 13:54 ` [PATCH AUTOSEL 4.4 11/15] powerpc/boot: Ensure _zimage_start is a weak symbol Sasha Levin
2018-11-04 13:54 ` [PATCH AUTOSEL 4.4 12/15] sc16is7xx: Fix for multi-channel stall Sasha Levin
2018-11-04 13:54 ` [PATCH AUTOSEL 4.4 13/15] media: tvp5150: fix width alignment during set_selection() Sasha Levin
2018-11-04 13:54 ` [PATCH AUTOSEL 4.4 14/15] 9p locks: fix glock.client_id leak in do_lock Sasha Levin
2018-11-04 13:54 ` [PATCH AUTOSEL 4.4 15/15] 9p: clear dangling pointers in p9stat_free Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181104135417.88671-10-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=dzhu@wavecomp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=paul.burton@mips.com \
--cc=pburton@wavecomp.com \
--cc=rachel.mozes@intel.com \
--cc=ralf@linux-mips.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).