From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:33282 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387905AbeKGBQE (ORCPT ); Tue, 6 Nov 2018 20:16:04 -0500 Date: Tue, 6 Nov 2018 10:50:12 -0500 From: Sasha Levin To: Jack Wang Cc: stable@vger.kernel.org, linux-kernel@vger.kernel.org, shli@fb.com Subject: Re: [PATCH AUTOSEL 4.19 118/146] MD: fix invalid stored role for a disk Message-ID: <20181106155012.GC151445@sasha-vm> References: <20181031230541.28822-1-sashal@kernel.org> <20181031230541.28822-118-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: stable-owner@vger.kernel.org List-ID: On Tue, Nov 06, 2018 at 08:37:32AM +0100, Jack Wang wrote: >Sasha Levin 于2018年11月1日周四 上午12:45写道： >> >> From: Shaohua Li >> >> [ Upstream commit d595567dc4f0c1d90685ec1e2e296e2cad2643ac ] >> >> If we change the number of array's device after device is removed from array, >> then add the device back to array, we can see that device is added as active >> role instead of spare which we expected. >> >> Please see the below link for details: >> https://marc.info/?l=linux-raid&m=153736982015076&w=2 >> >> This is caused by that we prefer to use device's previous role which is >> recorded by saved_raid_disk, but we should respect the new number of >> conf->raid_disks since it could be changed after device is removed. >> >> Reported-by: Gioh Kim >> Tested-by: Gioh Kim >> Acked-by: Guoqing Jiang 9e753ba9b9b405e3902d9f08aec5f2ea58a0c317 >> Signed-off-by: Shaohua Li >> Signed-off-by: Sasha Levin >Hi Sasha, > >This patch breaks linear hotadd please also include commit >9e753ba9b9b405e3902d9f08aec5f2ea58a0c317 >MD: fix invalid stored role for a disk - try2 I'll queue it up, thanks Jack! -- Thanks, Sasha