From: Sasha Levin <sashal@kernel.org>
To: Amir Goldstein <amir73il@gmail.com>
Cc: pvorel@suse.cz, Cyril Hrubis <chrubis@suse.cz>,
ltp@lists.linux.it, Sasha Levin <alexander.levin@microsoft.com>,
Jan Kara <jack@suse.cz>, stable <stable@vger.kernel.org>
Subject: Re: [PATCH 1/1] syscalls/fanotify10: Require kernel v4.19
Date: Tue, 6 Nov 2018 12:46:41 -0500 [thread overview]
Message-ID: <20181106174641.GE151445@sasha-vm> (raw)
In-Reply-To: <CAOQ4uxjVnAUYfH8_fuHXruObt1WVqObHxQxLmCxcPCNL-S5PjQ@mail.gmail.com>
On Tue, Nov 06, 2018 at 03:32:33PM +0200, Amir Goldstein wrote:
>On Tue, Nov 6, 2018 at 3:06 PM Petr Vorel <pvorel@suse.cz> wrote:
>>
>> Hi Amir,
>>
>> > There must be some confusion.
>> > FAN_MARK_MOUNT was NOT added in v4.19-rc2.
>> > It has been there from the start.
>> > FAN_MARK_INODE was NOT added either
>> > the define FAN_MARK_INODE 0 is just a convenience readability define
>> > it does not change the API.
>> I'm sorry, you're right.
>>
>> > You may be confusing with FAN_MARK_FILESYSTEM
>> > just was just added in kernel v4.20-rc1.
>> > The extension of tests to cover FAN_MARK_FILESYSTEM
>> > is waiting in my queue:
>> > https://github.com/amir73il/ltp/commits/fanotify_sb
>>
>> > And it already includes runtime checks for FAN_MARK_FILESYSTEM
>> > support.
>>
>> > Did I miss anything?
>> Testing your branch on older kernel, fanotify10 fails earlier than new TCONF
>
>Because fanotify10 checks for a bug that existed since the beginning
>and fixed by 9bdda4e9cf2d fsnotify: fix ignore mask logic in fsnotify().
>So test SHOULD fail until the backported patch is applied to the old kernel.
>
>The patch does not apply cleanly to kernels <= v4.17.
>Tested backport patch for v4.14.y attached.
Queued for 4.14, thanks Amir.
--
Thanks,
Sasha
prev parent reply other threads:[~2018-11-07 3:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181106124802.27170-1-pvorel@suse.cz>
[not found] ` <20181106125015.GB4834@rei.lan>
[not found] ` <20181106125556.GA28469@dell5510>
[not found] ` <CAOQ4uxhd9XZj=zvkm1j8mZBkBRw0qhvfwcaRQKzs24bVjsfUZw@mail.gmail.com>
[not found] ` <20181106130641.GB28469@dell5510>
2018-11-06 13:32 ` [PATCH 1/1] syscalls/fanotify10: Require kernel v4.19 Amir Goldstein
2018-11-06 17:46 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181106174641.GE151445@sasha-vm \
--to=sashal@kernel.org \
--cc=alexander.levin@microsoft.com \
--cc=amir73il@gmail.com \
--cc=chrubis@suse.cz \
--cc=jack@suse.cz \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox