From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 8 Nov 2018 09:25:58 -0800 From: Tony Lindgren To: Janusz Krzysztofik Cc: Aaro Koskinen , Greg Kroah-Hartman , Jiri Slaby , linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] ARM: OMAP1: ams-delta: Fix possible use of uninitialized field Message-ID: <20181108172558.GO56134@atomide.com> References: <20181107213031.21650-1-jmkrzyszt@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181107213031.21650-1-jmkrzyszt@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: * Janusz Krzysztofik [181107 13:28]: > While playing with initialization order of modem device, it has been > discovered that under some circumstances (early console init, I > believe) its .pm() callback may be called before the > uart_port->private_data pointer is initialized from > plat_serial8250_port->private_data, resulting in NULL pointer > dereference. Fix it by checking for uninitialized pointer before using > it in modem_pm(). Applying into omap-for-v4.20/fixes thanks. Tony