From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 16 Nov 2018 15:49:06 +0800 From: Ming Lei To: Sasha Levin Cc: Jens Axboe , linux-block@vger.kernel.org, Guenter Roeck , Greg Kroah-Hartman , stable@vger.kernel.org Subject: Re: [PATCH 1/2] blk-mq: not embed .mq_kobj and ctx->kobj into queue instance Message-ID: <20181116074905.GB5520@ming.t460p> References: <20181116032826.11901-1-ming.lei@redhat.com> <20181116032826.11901-2-ming.lei@redhat.com> <20181116065205.GD1706@sasha-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181116065205.GD1706@sasha-vm> List-ID: On Fri, Nov 16, 2018 at 01:52:05AM -0500, Sasha Levin wrote: > On Fri, Nov 16, 2018 at 11:28:25AM +0800, Ming Lei wrote: > > Even though .mq_kobj, ctx->kobj and q->kobj share same lifetime > > from block layer's view, actually they don't because userspace may > > grab one kobject anytime via sysfs, so each kobject's lifetime has > > to be independent, then the objects(mq_kobj, ctx) which hosts its > > own kobject have to be allocated dynamically. > > > > This patch fixes kernel panic issue during booting when DEBUG_KOBJECT_RELEASE > > is enabled. > > > > Reported-by: Guenter Roeck > > Cc: Guenter Roeck > > Cc: Greg Kroah-Hartman > > Cc: stable@vger.kernel.org > > Signed-off-by: Ming Lei > > What does this patch depend on? It doesn't apply to Linus's tree nor to > the block tree. > > Also, could you please cc lkml with patches? It depends on for-4.21/block. thanks, Ming