From: Sasha Levin <sashal@kernel.org>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org,
James Bottomley <James.Bottomley@HansenPartnership.com>,
Tomas Winkler <tomas.winkler@intel.com>,
Tadeusz Struk <tadeusz.struk@intel.com>,
Stefan Berger <stefanb@linux.vnet.ibm.com>,
Nayna Jain <nayna@linux.ibm.com>,
stable@vger.kernel.org, Peter Huewe <peterhuewe@gmx.de>,
Jason Gunthorpe <jgg@ziepe.ca>, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v8 08/17] tpm: call tpm2_flush_space() on error in tpm_try_transmit()
Date: Fri, 16 Nov 2018 11:19:57 -0500 [thread overview]
Message-ID: <20181116161957.GG1706@sasha-vm> (raw)
In-Reply-To: <20181116123845.15705-9-jarkko.sakkinen@linux.intel.com>
On Fri, Nov 16, 2018 at 02:38:32PM +0200, Jarkko Sakkinen wrote:
>Always call tpm2_flush_space() on failure in tpm_try_transmit() so that
>the volatile memory of the TPM gets cleared. If /dev/tpm0 does not have
>sufficient permissions (usually it has), this could lead to the leakage
>of TPM objects. Through /dev/tpmrm0 this issue does not raise any new
>security concerns.
>
>Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
>Cc: stable@vger.kernel.org
>Fixes: 745b361e989a ("tpm:tpm: infrastructure for TPM spaces")
>Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
>Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
Hi Jarkko,
This patch seems to depend on previous patches in this series, but those
were not tagged for stable. Do they also need to be backported? If so,
can you tag them as such?
--
Thanks,
Sasha
next prev parent reply other threads:[~2018-11-17 2:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181116123845.15705-1-jarkko.sakkinen@linux.intel.com>
2018-11-16 12:38 ` [PATCH v8 08/17] tpm: call tpm2_flush_space() on error in tpm_try_transmit() Jarkko Sakkinen
2018-11-16 16:19 ` Sasha Levin [this message]
2018-11-18 7:36 ` Jarkko Sakkinen
2018-11-18 23:21 ` Sasha Levin
2018-11-19 12:57 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181116161957.GG1706@sasha-vm \
--to=sashal@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=nayna@linux.ibm.com \
--cc=peterhuewe@gmx.de \
--cc=stable@vger.kernel.org \
--cc=stefanb@linux.vnet.ibm.com \
--cc=tadeusz.struk@intel.com \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox