From: Sasha Levin <sashal@kernel.org>
To: Loic <hackurx@opensec.fr>
Cc: stable@vger.kernel.org, v.maffione@gmail.com,
aaron.f.brown@intel.com, jeffrey.t.kirsher@intel.com
Subject: Re: [PATCH] e1000: fix race condition between e1000_down() and e1000_watchdog
Date: Sat, 17 Nov 2018 09:37:34 -0500 [thread overview]
Message-ID: <20181117143734.GO1706@sasha-vm> (raw)
In-Reply-To: <20181109141233.e8737d6d77b38bfcd4ed6423@opensec.fr>
On Fri, Nov 09, 2018 at 02:12:33PM +0100, Loic wrote:
>Hello,
>
>Please picked up this patch for linux 4.4 and 4.9.
>Compiled/tested without problem.
>
>Thank.
>
>[ Upstream commit 44c445c3d1b4eacff23141fa7977c3b2ec3a45c9 ]
>
>From: Vincenzo Maffione <v.maffione@gmail.com>
>Date: Sat, 16 Sep 2017 18:00:00 +0200
>Subject: [PATCH] e1000: fix race condition between e1000_down() and
> e1000_watchdog
>
>This patch fixes a race condition that can result into the interface being
>up and carrier on, but with transmits disabled in the hardware.
>The bug may show up by repeatedly IFF_DOWN+IFF_UP the interface, which
>allows e1000_watchdog() interleave with e1000_down().
>
> CPU x CPU y
> --------------------------------------------------------------------
> e1000_down():
> netif_carrier_off()
> e1000_watchdog():
> if (carrier == off) {
> netif_carrier_on();
> enable_hw_transmit();
> }
> disable_hw_transmit();
> e1000_watchdog():
> /* carrier on, do nothing */
>
>Signed-off-by: Vincenzo Maffione <v.maffione@gmail.com>
>Tested-by: Aaron Brown <aaron.f.brown@intel.com>
>Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Queued for 4.9 and 4.4, thank you.
--
Thanks,
Sasha
prev parent reply other threads:[~2018-11-18 0:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-09 13:12 [PATCH] e1000: fix race condition between e1000_down() and e1000_watchdog Loic
2018-11-17 14:37 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181117143734.GO1706@sasha-vm \
--to=sashal@kernel.org \
--cc=aaron.f.brown@intel.com \
--cc=hackurx@opensec.fr \
--cc=jeffrey.t.kirsher@intel.com \
--cc=stable@vger.kernel.org \
--cc=v.maffione@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox