From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:54984 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726020AbeKRAyt (ORCPT ); Sat, 17 Nov 2018 19:54:49 -0500 Date: Sat, 17 Nov 2018 09:37:56 -0500 From: Sasha Levin To: Loic Cc: stable@vger.kernel.org, colin.king@canonical.com, alexander.h.duyck@intel.com, aaron.f.brown@intel.com, jeffrey.t.kirsher@intel.com Subject: Re: [PATCH] e1000: avoid null pointer dereference on invalid stat type Message-ID: <20181117143756.GP1706@sasha-vm> References: <20181109141706.044436edb88f95b9aacc7cb3@opensec.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20181109141706.044436edb88f95b9aacc7cb3@opensec.fr> Sender: stable-owner@vger.kernel.org List-ID: On Fri, Nov 09, 2018 at 02:17:06PM +0100, Loic wrote: >Hello, > >Please picked up this patch for linux 4.4 and 4.9. >Compiled/tested without problem. > >Thank. > >[ Upstream commit 5983587c8c5ef00d6886477544ad67d495bc5479 ] > >From: Colin Ian King >Date: Fri, 22 Sep 2017 18:13:48 +0100 >Subject: [PATCH] e1000: avoid null pointer dereference on invalid stat type > >Currently if the stat type is invalid then data[i] is being set >either by dereferencing a null pointer p, or it is reading from >an incorrect previous location if we had a valid stat type >previously. Fix this by skipping over the read of p on an invalid >stat type. > >Detected by CoverityScan, CID#113385 ("Explicit null dereferenced") > >Signed-off-by: Colin Ian King >Reviewed-by: Alexander Duyck >Tested-by: Aaron Brown >Signed-off-by: Jeff Kirsher Queued for 4.9 and 4.4, thank you. -- Thanks, Sasha