From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 19 Nov 2018 14:57:04 +0200 From: Jarkko Sakkinen To: Sasha Levin Cc: linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, James Bottomley , Tomas Winkler , Tadeusz Struk , Stefan Berger , Nayna Jain , stable@vger.kernel.org, Peter Huewe , Jason Gunthorpe , Arnd Bergmann , Greg Kroah-Hartman , open list Subject: Re: [PATCH v8 08/17] tpm: call tpm2_flush_space() on error in tpm_try_transmit() Message-ID: <20181119125704.GC8755@linux.intel.com> References: <20181116123845.15705-1-jarkko.sakkinen@linux.intel.com> <20181116123845.15705-9-jarkko.sakkinen@linux.intel.com> <20181116161957.GG1706@sasha-vm> <20181118073618.GD5897@linux.intel.com> <20181118232157.GA1711@sasha-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181118232157.GA1711@sasha-vm> List-ID: On Sun, Nov 18, 2018 at 06:21:57PM -0500, Sasha Levin wrote: > There's no "preferred" approach really. I try to warn about cases like > this early because the response rates to Greg's "FAILED" email seem to > be low - by the time they are sent out people are done with that code > and have moved on. > > In this scenario, for exmaple, this patch would not apply to any stable > tree because it depends on a previous patch in this series that was not > tagged for stable. My hopes are that if I warn you about this early you > can work around this (for example, by marking that prior patch for > stable as well) so you won't need to deal with this patch again in a few > weeks. > > There's no need to change anything about your flow if it works for you. Ok, I see. Yeah, it is just how I organize my work. Rather solve the patch dependency sudoku one time than two times. When I maintain a subsystem I've thought that it is my responsibility to always do that and not wait someone else to do it for me :-) That is the responsibility part of the equation when you have the power to decide what gets in. Right now I have two failed merges in my queue that I plan to take care of them next week. > Thanks, > Sasha /Jarkko