Re: WTF: patch "[PATCH] SUNRPC: drop pointless static qualifier in" was seriously submitted to be applied to the 4.19-stable tree?

Sasha Levin
2018-11-24T06:01:37Z

On Mon, Nov 19, 2018 at 12:03:28PM -0500, J. Bruce Fields wrote:
>On Mon, Nov 19, 2018 at 01:45:19PM +0100, gregkh@linuxfoundation.org wrote:
>> The patch below was submitted to be applied to the 4.19-stable tree.
>>
>> I fail to see how this patch meets the stable kernel rules as found at
>> Documentation/process/stable-kernel-rules.rst.
>
>I should have rewritten that changelog, Yue Hainbing's makes it just
>sound like cleanup.
>
>That variable should definitely be private to each task, the sharing
>could cause real bugs.
>
>Admittedly, I don't have actual bug reports, so you could argue this
>falls under the 'No "theoretical race condition"' rule, but the
>potential consequences are pretty bad and the fix very simple, so I
>still think it's a good stable candidate.

Thanks for the explanation, I've queued it for all stable branches.

--
Thanks,
Sasha