From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from new4-smtp.messagingengine.com ([66.111.4.230]:39603 "EHLO
        new4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1725851AbeKTTWY (ORCPT
        <rfc822;stable@vger.kernel.org>); Tue, 20 Nov 2018 14:22:24 -0500
Date: Tue, 20 Nov 2018 09:54:19 +0100
From: Greg KH <greg@kroah.com>
To: Jean Delvare <jdelvare@suse.de>
Cc: stable@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>,
        Erik Schmauss <erik.schmauss@intel.com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Subject: Re: Please revert "ACPICA: AML interpreter: add region addresses in
 global list during initialization"
Message-ID: <20181120085419.GA19171@kroah.com>
References: <20181120094649.243f9670@endymion>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20181120094649.243f9670@endymion>
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Tue, Nov 20, 2018 at 09:46:49AM +0100, Jean Delvare wrote:
> Dear stable kernel team,
> 
> In stable kernel 4.19.2, the following upstream commit was included:
> 
> commit 4abb951b73ff0a8a979113ef185651aa3c8da19b
> Author: Erik Schmauss
> Date:   Wed Oct 17 14:09:35 2018 -0700
> 
>     ACPICA: AML interpreter: add region addresses in global list during initialization
> 
> This commit was tagged with:
> 
>     Link: https://bugzilla.kernel.org/show_bug.cgi?id=200011
>     Tested-by: Jean-Marc Lenoir
>     Cc: All applicable <stable@vger.kernel.org>
> 
> making it sound like it was fixing an actual bug. This is not the case.
> The commit fixes a side issue discovered while investigating bug
> #200011. It does NOT fix bug #200011 itself (as explicitly reported by
> Jean-Marc at https://bugzilla.kernel.org/show_bug.cgi?id=200011#c65 ).
> 
> It does however cause regressions, despite what the commit message says. See:
> 
> https://bugzilla.kernel.org/show_bug.cgi?id=201721
> 
> and I expect more similar regressions, as ACPI resource conflicts are
> very frequent.
> 
> This commit was not stable material to start with. It is intrusive,
> presents a risk of side effects, and does not solve an actual bug that
> is bothering users.
> 
> Please revert this commit from future stable kernels on all affected
> branches (I think only 4.18.19 and 4.19.2 are affected at the moment,
> but maybe other affected releases are in the works already).

Ok, I'll go revert this, but shouldn't it also be reverted in Linus's
tree as well?

thanks,

greg k-h