public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <jdelvare@suse.de>
To: stable@vger.kernel.org
Cc: Guenter Roeck <linux@roeck-us.net>,
	Erik Schmauss <erik.schmauss@intel.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Subject: Please revert "ACPICA: AML interpreter: add region addresses in global list during initialization"
Date: Tue, 20 Nov 2018 09:46:49 +0100	[thread overview]
Message-ID: <20181120094649.243f9670@endymion> (raw)

Dear stable kernel team,

In stable kernel 4.19.2, the following upstream commit was included:

commit 4abb951b73ff0a8a979113ef185651aa3c8da19b
Author: Erik Schmauss
Date:   Wed Oct 17 14:09:35 2018 -0700

    ACPICA: AML interpreter: add region addresses in global list during initialization

This commit was tagged with:

    Link: https://bugzilla.kernel.org/show_bug.cgi?id=200011
    Tested-by: Jean-Marc Lenoir
    Cc: All applicable <stable@vger.kernel.org>

making it sound like it was fixing an actual bug. This is not the case.
The commit fixes a side issue discovered while investigating bug
#200011. It does NOT fix bug #200011 itself (as explicitly reported by
Jean-Marc at https://bugzilla.kernel.org/show_bug.cgi?id=200011#c65 ).

It does however cause regressions, despite what the commit message says. See:

https://bugzilla.kernel.org/show_bug.cgi?id=201721

and I expect more similar regressions, as ACPI resource conflicts are
very frequent.

This commit was not stable material to start with. It is intrusive,
presents a risk of side effects, and does not solve an actual bug that
is bothering users.

Please revert this commit from future stable kernels on all affected
branches (I think only 4.18.19 and 4.19.2 are affected at the moment,
but maybe other affected releases are in the works already).

Thanks,
-- 
Jean Delvare
SUSE L3 Support

             reply	other threads:[~2018-11-20 19:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-20  8:46 Jean Delvare [this message]
2018-11-20  8:54 ` Please revert "ACPICA: AML interpreter: add region addresses in global list during initialization" Greg KH
2018-11-20  9:03   ` Jean Delvare
2018-11-20  9:11     ` Greg KH
2018-11-20 18:30       ` Schmauss, Erik
2018-11-21  8:04         ` Greg KH
2018-11-22  1:30           ` Schmauss, Erik
2018-11-21  8:45         ` Jean Delvare
     [not found]           ` <CF6A88132359CE47947DB4C6E1709ED53C5508FA@ORSMSX122.amr.corp.intel.com>
2018-11-28  0:27             ` Schmauss, Erik
2018-11-28  8:56               ` Jean Delvare
2018-11-28 10:55                 ` 'Greg KH'

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181120094649.243f9670@endymion \
    --to=jdelvare@suse.de \
    --cc=erik.schmauss@intel.com \
    --cc=linux@roeck-us.net \
    --cc=rafael.j.wysocki@intel.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox