Re: [PATCH v2] x86/fpu: Disable BH while while loading FPU registers in __fpu__restore_sig()

Re: [PATCH v2] x86/fpu: Disable BH while while loading FPU registers in __fpu__restore_sig()

[Borislav Petkov]

On Tue, Nov 20, 2018 at 01:25:30PM +0000, Sasha Levin wrote:
> Hi,
> 
> [This is an automated email]
> 
> This commit has been processed because it contains a -stable tag.
> The stable tag indicates that it's relevant for the following trees: all
> 
> The bot has tested the following trees: v4.19.2, v4.18.19, v4.14.81, v4.9.137, v4.4.163, v3.18.125.
> 
> v4.19.2: Build OK!
> v4.18.19: Build OK!
> v4.14.81: Build OK!
> v4.9.137: Failed to apply! Possible dependencies:
>     Unable to calculate

AFAIR, Victoria asked about this fix a while ago. CCed.

Victoria, do you still need this patch in your 4.9? If so, you might
wanna give it a try:

https://git.kernel.org/tip/68239654acafe6aad5a3c1dc7237e60accfebc03

Let us know if you need help backporting - it should be easy though.

HTH.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

Re: [PATCH v2] x86/fpu: Disable BH while while loading FPU registers in __fpu__restore_sig()

[Victoria Anosova]

[-- Attachment #1: Type: text/plain, Size: 1184 bytes --]

Hello Boris,

Glad this come to kernel. We've already applied this patch.
Thank you for your help.

Regards,
Victoria.

вт, 20 нояб. 2018 г. в 23:34, Borislav Petkov <bp@alien8.de>:

> On Tue, Nov 20, 2018 at 01:25:30PM +0000, Sasha Levin wrote:
> > Hi,
> >
> > [This is an automated email]
> >
> > This commit has been processed because it contains a -stable tag.
> > The stable tag indicates that it's relevant for the following trees: all
> >
> > The bot has tested the following trees: v4.19.2, v4.18.19, v4.14.81,
> v4.9.137, v4.4.163, v3.18.125.
> >
> > v4.19.2: Build OK!
> > v4.18.19: Build OK!
> > v4.14.81: Build OK!
> > v4.9.137: Failed to apply! Possible dependencies:
> >     Unable to calculate
>
> AFAIR, Victoria asked about this fix a while ago. CCed.
>
> Victoria, do you still need this patch in your 4.9? If so, you might
> wanna give it a try:
>
> https://git.kernel.org/tip/68239654acafe6aad5a3c1dc7237e60accfebc03
>
> Let us know if you need help backporting - it should be easy though.
>
> HTH.
>
> --
> Regards/Gruss,
>     Boris.
>
> Good mailing practices for 400: avoid top-posting and trim the reply.
>

[-- Attachment #2: Type: text/html, Size: 1714 bytes --]

Re: [PATCH v2] x86/fpu: Disable BH while while loading FPU registers in __fpu__restore_sig()

[Borislav Petkov]

On Wed, Nov 21, 2018 at 11:11:18AM +0500, Victoria Anosova wrote:
> Glad this come to kernel. We've already applied this patch.

The current version, with the bottom half toggling or the original one
with preempt_disable/enable?

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

Re: [PATCH v2] x86/fpu: Disable BH while while loading FPU registers in __fpu__restore_sig()

[Victoria Anosova]

[-- Attachment #1: Type: text/plain, Size: 530 bytes --]

For v4.9 your first fix (
https://lists.openwall.net/linux-kernel/2016/02/26/299) helped.

ср, 21 нояб. 2018 г. в 15:56, Borislav Petkov <bp@alien8.de>:

> On Wed, Nov 21, 2018 at 11:11:18AM +0500, Victoria Anosova wrote:
> > Glad this come to kernel. We've already applied this patch.
>
> The current version, with the bottom half toggling or the original one
> with preempt_disable/enable?
>
> --
> Regards/Gruss,
>     Boris.
>
> Good mailing practices for 400: avoid top-posting and trim the reply.
>

[-- Attachment #2: Type: text/html, Size: 880 bytes --]

Re: [PATCH v2] x86/fpu: Disable BH while while loading FPU registers in __fpu__restore_sig()

[Boris Petkov]

On November 21, 2018 1:41:37 PM GMT+01:00, Victoria Anosova <v.s.anosova@gmail.com> wrote:
>For v4.9 your first fix (
>https://lists.openwall.net/linux-kernel/2016/02/26/299) helped.

Can you please not top-post? Thx.

That old version is not quite right - see the commit message of the current fix.

HTH.

-- 
Sent from a small device: formatting sux and brevity is inevitable.