From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:46796 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728243AbeKXGBh (ORCPT ); Sat, 24 Nov 2018 01:01:37 -0500 Date: Fri, 23 Nov 2018 14:15:59 -0500 From: Sasha Levin To: "J. Bruce Fields" Cc: gregkh@linuxfoundation.org, yuehaibing@huawei.com, stable@vger.kernel.org Subject: Re: WTF: patch "[PATCH] SUNRPC: drop pointless static qualifier in" was seriously submitted to be applied to the 4.19-stable tree? Message-ID: <20181123191559.GE1917@sasha-vm> References: <154263151989125@kroah.com> <20181119170327.GA3814@parsley.fieldses.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20181119170327.GA3814@parsley.fieldses.org> Sender: stable-owner@vger.kernel.org List-ID: On Mon, Nov 19, 2018 at 12:03:28PM -0500, J. Bruce Fields wrote: >On Mon, Nov 19, 2018 at 01:45:19PM +0100, gregkh@linuxfoundation.org wrote: >> The patch below was submitted to be applied to the 4.19-stable tree. >> >> I fail to see how this patch meets the stable kernel rules as found at >> Documentation/process/stable-kernel-rules.rst. > >I should have rewritten that changelog, Yue Hainbing's makes it just >sound like cleanup. > >That variable should definitely be private to each task, the sharing >could cause real bugs. > >Admittedly, I don't have actual bug reports, so you could argue this >falls under the 'No "theoretical race condition"' rule, but the >potential consequences are pretty bad and the fix very simple, so I >still think it's a good stable candidate. Thanks for the explanation, I've queued it for all stable branches. -- Thanks, Sasha