From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:47590 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726004AbeKXGEB (ORCPT ); Sat, 24 Nov 2018 01:04:01 -0500 Date: Fri, 23 Nov 2018 14:18:24 -0500 From: Sasha Levin To: Andreas Gruenbacher Cc: stable@vger.kernel.org Subject: Re: [PATCH] gfs2: Put bitmap buffers in put_super Message-ID: <20181123191824.GF1917@sasha-vm> References: <20181119162232.15253-1-agruenba@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20181119162232.15253-1-agruenba@redhat.com> Sender: stable-owner@vger.kernel.org List-ID: On Mon, Nov 19, 2018 at 05:22:32PM +0100, Andreas Gruenbacher wrote: >commit 10283ea525d30f2e99828978fd04d8427876a7ad upstream. > >gfs2_put_super calls gfs2_clear_rgrpd to destroy the gfs2_rgrpd objects >attached to the resource group glocks. That function should release the >buffers attached to the gfs2_bitmap objects (bi_bh), but the call to >gfs2_rgrp_brelse for doing that is missing. > >When gfs2_releasepage later runs across these buffers which are still >referenced, it refuses to free them. This causes the pages the buffers >are attached to to remain referenced as well. With enough mount/unmount >cycles, the system will eventually run out of memory. > >Fix this by adding the missing call to gfs2_rgrp_brelse in >gfs2_clear_rgrpd. > >(Also fix a gfs2_rgrp_relse -> gfs2_rgrp_brelse typo in a comment.) > >Fixes: 39b0f1e92908 ("GFS2: Don't brelse rgrp buffer_heads every allocation") >Cc: stable@vger.kernel.org # v4.9 >Signed-off-by: Andreas Gruenbacher I've queued both patches to their appropriate branches, thank you. -- Thanks, Sasha