From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:43298 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731843AbeKXQii (ORCPT ); Sat, 24 Nov 2018 11:38:38 -0500 Date: Sat, 24 Nov 2018 00:51:25 -0500 From: Sasha Levin To: Steve French Cc: Stable , samba-technical , CIFS , stijn@linux-ipv6.be, ronnie sahlberg Subject: Re: Fwd: NULL pointer dereference in smb2_queryfs with v4.19.2 Message-ID: <20181124055125.GN1917@sasha-vm> References: <9cdc7319-32f9-8349-a787-99d6ea973669@linux-ipv6.be> <20181123194303.GJ1917@sasha-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: Sender: stable-owner@vger.kernel.org List-ID: On Fri, Nov 23, 2018 at 05:21:09PM -0600, Steve French wrote: >---------- Forwarded message --------- >From: Sasha Levin >Date: Fri, Nov 23, 2018 at 1:43 PM >Subject: Re: NULL pointer dereference in smb2_queryfs with v4.19.2 >To: Steve French >Cc: , Stable , CIFS >, samba-technical > > > >On Tue, Nov 20, 2018 at 02:16:15PM -0600, Steve French wrote: >>At first glance it looks like it is missing from the 4.19 stable tree >>On Tue, Nov 20, 2018 at 2:14 PM Steve French wrote: >>> >>> Do you know if you are running with this patch (which was marked for stable) > > >> This commit depends on ba8ca116854 ("cifs: create helpers for >>SMB2_set_info_init/free()") which is not marked for stable and is not >>trivial. >> >> If anyone wants to send a backport I'd be happy to queue this patch up. > >That should not be needed. >The dependency you mention - "create helpers for >SMB2_set_info_init/free..." is already in 4.19 and is the patch which >the stable patch requested ("allow calling SMB2_xxx_free...") fixes. Hm, it's not in 4.19 - it was merged during the 4.20 merge window. -- Thanks, Sasha