From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:37218 "EHLO
        foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1727673AbeK1XGL (ORCPT <rfc822;stable@vger.kernel.org>);
        Wed, 28 Nov 2018 18:06:11 -0500
Date: Wed, 28 Nov 2018 12:05:02 +0000
From: Will Deacon <will.deacon@arm.com>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Naresh Kamboju <naresh.kamboju@linaro.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Ingo Molnar <mingo@redhat.com>,
        Masami Hiramatsu <masami.hiramatsu@linaro.org>,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        AKASHI Takahiro <takahiro.akashi@linaro.org>
Subject: Re: [PATCH] arm64: ftrace: Fix to enable syscall events on arm64
Message-ID: <20181128120502.GC24868@arm.com>
References: <CAA93ih1-xpm1P0suT6SNCc_ARvAfyBEwb0-uKFikM5k4CvG8jg@mail.gmail.com>
 <154333618522.27355.8094935453351562295.stgit@devbox>
 <20181127165848.GA19569@arm.com>
 <20181127131859.79ce7da9@gandalf.local.home>
 <20181128085555.a8987cbe18aa6d1d1f0a827e@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20181128085555.a8987cbe18aa6d1d1f0a827e@kernel.org>
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

Hi Masami,

On Wed, Nov 28, 2018 at 08:55:55AM +0900, Masami Hiramatsu wrote:
> On Tue, 27 Nov 2018 13:18:59 -0500
> Steven Rostedt <rostedt@goodmis.org> wrote:
> 
> > On Tue, 27 Nov 2018 16:58:49 +0000
> > Will Deacon <will.deacon@arm.com> wrote:
> > 
> > > This looks fine to me, but I'm curious about whether this is supposed to
> > > work with compat syscalls as well, where the prefix is "__arm64_compat_".
> > > 
> > > If we broadly follow the x86 lead, we'd have:
> > > 
> > > 	return (!strncmp(sym, "__arm64_", 8) && !strcmp(sym + 8, name)) ||
> > > 		(!strncmp(sym, "__arm64_compat_", 15) && !strcmp(sym + 15, name));
> > > 
> > > Do we need to handle compat (i.e. 32-bit) tasks here?
> > 
> > Only if you want to trace compat syscalls as well ;-)
> 
> Actually I thought about that, but I found below comment in
> arch/arm64/include/asm/ftrace.h
> 
>  * Because AArch32 mode does not share the same syscall table with AArch64,
>  * tracing compat syscalls may result in reporting bogus syscalls or even
>  * hang-up, so just do not trace them.
> 
> That's why I dropped compat syscall support.

Ok! Then please add a comment to arch_syscall_match_sym_name() along those
lines, and you can add my ack:

Acked-by: Will Deacon <will.deacon@arm.com>

Thanks,

Will