public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
To: dri-devel@lists.freedesktop.org
Cc: martin.peres@intel.com, ville.syrjala@intel.com,
	chris@chris-wilson.co.uk, stable@vger.kernel.org,
	stanislav.lisovskiy@intel.com, intel-gfx@lists.freedesktop.org
Subject: [PATCH v2] Return only active connectors for get_resources ioctl
Date: Wed, 28 Nov 2018 15:55:58 +0200	[thread overview]
Message-ID: <20181128135558.3679-1-stanislav.lisovskiy@intel.com> (raw)

Currently kernel might allocate different connector ids
for the same outputs in case of DP MST, which seems to
confuse userspace. There are can be different connector
ids in the list, which could be assigned to the same
output, while being in different states.
This results in issues, like external displays staying
blank after quick unplugging and plugging back(bug #106250).
Returning only active DP connectors fixes the issue.

v2: Removed caps from the title

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106250
Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
---
 drivers/gpu/drm/drm_mode_config.c | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/drm_mode_config.c b/drivers/gpu/drm/drm_mode_config.c
index ee80788f2c40..ec5b2b08a45e 100644
--- a/drivers/gpu/drm/drm_mode_config.c
+++ b/drivers/gpu/drm/drm_mode_config.c
@@ -143,6 +143,7 @@ int drm_mode_getresources(struct drm_device *dev, void *data,
 	drm_connector_list_iter_begin(dev, &conn_iter);
 	count = 0;
 	connector_id = u64_to_user_ptr(card_res->connector_id_ptr);
+	DRM_DEBUG_KMS("GetResources: writing connectors start");
 	drm_for_each_connector_iter(connector, &conn_iter) {
 		/* only expose writeback connectors if userspace understands them */
 		if (!file_priv->writeback_connectors &&
@@ -150,15 +151,20 @@ int drm_mode_getresources(struct drm_device *dev, void *data,
 			continue;
 
 		if (drm_lease_held(file_priv, connector->base.id)) {
-			if (count < card_res->count_connectors &&
-			    put_user(connector->base.id, connector_id + count)) {
-				drm_connector_list_iter_end(&conn_iter);
-				return -EFAULT;
+			if (connector->connector_type != DRM_MODE_CONNECTOR_DisplayPort ||
+				connector->status != connector_status_disconnected) {
+				if (count < card_res->count_connectors &&
+				    put_user(connector->base.id, connector_id + count)) {
+					drm_connector_list_iter_end(&conn_iter);
+					return -EFAULT;
+				}
+				DRM_DEBUG_KMS("GetResources: connector %s", connector->name);
+				count++;
 			}
-			count++;
 		}
 	}
 	card_res->count_connectors = count;
+	DRM_DEBUG_KMS("GetResources: writing connectors end - count %d", count);
 	drm_connector_list_iter_end(&conn_iter);
 
 	return ret;
-- 
2.17.1

             reply	other threads:[~2018-11-29  0:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-28 13:55 Stanislav Lisovskiy [this message]
2018-11-28 20:51 ` [Intel-gfx] [PATCH v2] Return only active connectors for get_resources ioctl Daniel Vetter
2018-11-28 21:21   ` Daniel Vetter
2018-11-28 21:24     ` Daniel Vetter
2018-11-29  7:37     ` Lisovskiy, Stanislav
2018-11-29  8:17       ` Lisovskiy, Stanislav
2018-11-29  8:48       ` Daniel Vetter
2018-11-29  9:15         ` Lisovskiy, Stanislav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181128135558.3679-1-stanislav.lisovskiy@intel.com \
    --to=stanislav.lisovskiy@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=martin.peres@intel.com \
    --cc=stable@vger.kernel.org \
    --cc=ville.syrjala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox