Re: [PATCH] mtd: nand: Fix memory allocation in nanddev_bbt_init()

Boris Brezillon
2018-11-29T02:30:25Z

On Wed, 28 Nov 2018 15:19:37 +0000
Schrempf Frieder <frieder.schrempf@kontron.de> wrote:

> On 28.11.18 16:02, Boris Brezillon wrote:
> > On Wed, 28 Nov 2018 14:55:45 +0000
> > Schrempf Frieder <frieder.schrempf@kontron.de> wrote:
> >
> >> Hi Boris,
> >>
> >> On 28.11.18 15:41, Boris Brezillon wrote:
> >>> On Tue, 27 Nov 2018 07:44:52 +0000
> >>> Schrempf Frieder <frieder.schrempf@kontron.de> wrote:
> >>>
> >>>> Fix the size of the buffer allocated to store the in-memory BBT.
> >>>> This bug was previously hidden by a different bug, that was fixed in
> >>>> d098093ba06e.
> >>>>
> >>>> Fixes: 9c3736a3de21 ("mtd: nand: Add core infrastructure to deal with NAND devices")
> >>>> Cc: <stable@vger.kernel.org>
> >>>> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
> >>>
> >>> Looks like your From header does not match the SoB tag
> >>> ('Frieder Schrempf' vs 'Schrempf Frieder') and checkpatch does not like
> >>> that. I'll fix it when applying, but maybe you should fix
> >>> your .gitconfig to make them match.
> >>
> >> Actually the From header in my local patch is correct (<first name>
> >> <last name>, Frieder Schrempf) as it comes from my git config. But since
> >> our company was renamed and our mail servers were transferred, our
> >> e-mails are sent with From=<last name> <first name>.
> >>
> >> It seems like git send-email or patchwork or whatever uses the
> >> information from the e-mail header instead of what is in the patch.
> >>
> >> I will try to raise this issue with our IT department as this would be
> >> best fixed on their side.
> >
> > There's another solution: make git send-email add a From header in the
> > message body.
> >
> > git config --global sendemail.from "Schrempf Frieder <frieder.schrempf@kontron.de>"
>
> I don't get it. How would that change things? My From still wouldn't
> match my SoB tags.

When there's a From line in the message Body, git am will use this one
instead of the one in the header section.