From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:59638 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725776AbeK3G2I (ORCPT ); Fri, 30 Nov 2018 01:28:08 -0500 Date: Thu, 29 Nov 2018 20:21:37 +0100 From: Greg Kroah-Hartman To: "Schmauss, Erik" Cc: Jean Delvare , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , Jean-Marc Lenoir , "Wysocki, Rafael J" Subject: Re: [PATCH 4.14 044/100] ACPICA: AML interpreter: add region addresses in global list during initialization Message-ID: <20181129192136.GA13749@kroah.com> References: <20181129140058.768942700@linuxfoundation.org> <20181129140102.870510957@linuxfoundation.org> <1543502726.10991.13.camel@suse.de> <20181129150115.GA22451@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: stable-owner@vger.kernel.org List-ID: On Thu, Nov 29, 2018 at 06:56:40PM +0000, Schmauss, Erik wrote: > > > > -----Original Message----- > > From: Greg Kroah-Hartman [mailto:gregkh@linuxfoundation.org] > > Sent: Thursday, November 29, 2018 7:01 AM > > To: Jean Delvare > > Cc: linux-kernel@vger.kernel.org; stable@vger.kernel.org; Jean-Marc Lenoir > > ; Schmauss, Erik ; > > Wysocki, Rafael J > > Subject: Re: [PATCH 4.14 044/100] ACPICA: AML interpreter: add region > > addresses in global list during initialization > > > > On Thu, Nov 29, 2018 at 03:45:26PM +0100, Jean Delvare wrote: > > > Hi Greg, > > > > > > On Thu, 2018-11-29 at 15:12 +0100, Greg Kroah-Hartman wrote: > > > > 4.14-stable review patch. If anyone has any objections, please let me > > know. > > > > > > > > ------------------ > > > > > > > > From: Erik Schmauss > > > > > > > > commit 4abb951b73ff0a8a979113ef185651aa3c8da19b upstream. > > > > > > > > The table load process omitted adding the operation region address > > > > range to the global list. This omission is problematic because the > > > > OS queries the global list to check for address range conflicts > > > > before deciding which drivers to load. This commit may result in > > > > warning messages that look like the following: > > > > > > > > [ 7.871761] ACPI Warning: system_IO range 0x00000428-0x0000042F > > conflicts with op_region 0x00000400-0x0000047F (\PMIO) > > (20180531/utaddress-213) > > > > [ 7.871769] ACPI: If an ACPI driver is available for this device, you should > > use it instead of the native driver > > > > > > > > However, these messages do not signify regressions. It is a result > > > > of properly adding address ranges within the global address list. > > > > > > > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=200011 > > > > Tested-by: Jean-Marc Lenoir > > > > Signed-off-by: Erik Schmauss > > > > Cc: All applicable > > > > Signed-off-by: Rafael J. Wysocki > > > > Cc: Jean Delvare > > > > Signed-off-by: Greg Kroah-Hartman > > > > > > I'm confused. While we were discussing the regression, Erik said that > > > this is fixing commit 5a8361f7ecceaed64b4064000d16cb703462be49, which > > > went upstream in v4.17. So how can the fix be needed in any kernel > > > older than v4.17? Erik, did I understand you incorrectly? > > > Hi Greg, > > > The patch says "All applicable", and I assumed that meant, "as long as it > > applies." > > > > Erik, should I drop this from 4.14.y? > > This should only apply to 4.17 or later. I unintentionally put all applicable so > please drop this for all 4.16 or earlier. I've learned my lesson and I'll put the > correct tags from now on :-) Ok, now dropped from 4.14, thanks. greg k-h