suggest 21a268069203 ("mtd: rawnand: marvell: prevent harmless warnings") for inclusion into 4.18.x

suggest 21a268069203 ("mtd: rawnand: marvell: prevent harmless warnings") for inclusion into 4.18.x

[Uwe Kleine-König]

Hello,

maybe it's already on your radar because the commit has a Fixes: line
but to make sure you consider this: Commit

	21a268069203 ("mtd: rawnand: marvell: prevent harmless warnings") 

fixes the following warning for me:

[   14.135901] ------------[ cut here ]------------
[   14.140239] WARNING: CPU: 0 PID: 229 at /build/linux-QEquFP/linux-4.18.20/drivers/mtd/nand/raw/nand_base.c:2773 nand_subop_get_data_len+0x60/0xa4
[   14.152615] Modules linked in: marvell_nand(+) mvneta(+) mvmdio(+) phylink g762 orion_wdt leds_gpio ip_tables x_tables autofs4 btrfs libcrc32c crc32c_generic xor zstd_decompress zstd_compress xxhash zlib_deflate raid6_pq sd_mod gpio_pca953x ahci libahci libata scsi_mod i2c_mv64xxx
[   14.175598] CPU: 0 PID: 229 Comm: systemd-udevd Not tainted 4.18.0-3-armmp #1 Debian 4.18.20-2
[   14.183529] Hardware name: Marvell Armada 370/XP (Device Tree)
[   14.188923] [<c0316f60>] (unwind_backtrace) from [<c0310330>] (show_stack+0x20/0x24)
[   14.196062] [<c0310330>] (show_stack) from [<c0ac69fc>] (dump_stack+0x94/0xa8)
[   14.202726] [<c0ac69fc>] (dump_stack) from [<c0354138>] (__warn+0xf0/0x108)
[   14.209144] [<c0354138>] (__warn) from [<c0354288>] (warn_slowpath_null+0x50/0x58)
[   14.216119] [<c0354288>] (warn_slowpath_null) from [<c086bbf0>] (nand_subop_get_data_len+0x60/0xa4)
[   14.224492] [<c086bbf0>] (nand_subop_get_data_len) from [<bf39cc84>] (marvell_nfc_parse_instructions+0x6c/0x25c [marvell_nand])
[   14.235090] [<bf39cc84>] (marvell_nfc_parse_instructions [marvell_nand]) from [<bf39f348>] (marvell_nfc_naked_access_exec+0x38/0x1bc [marvell_nand])
[   14.247349] [<bf39f348>] (marvell_nfc_naked_access_exec [marvell_nand]) from [<c086c4cc>] (nand_op_parser_exec_op+0x2a8/0x4bc)
[   14.257847] [<c086c4cc>] (nand_op_parser_exec_op) from [<bf39ee70>] (marvell_nfc_exec_op+0x38/0x44 [marvell_nand])
[   14.267389] [<bf39ee70>] (marvell_nfc_exec_op [marvell_nand]) from [<c086e384>] (nand_reset_op+0x160/0x184)
[   14.276363] [<c086e384>] (nand_reset_op) from [<c086f254>] (nand_reset+0x60/0xc0)
[   14.283258] [<c086f254>] (nand_reset) from [<c087168c>] (nand_scan_ident+0x22c/0x12bc)
[   14.290560] [<c087168c>] (nand_scan_ident) from [<bf39e318>] (marvell_nand_chip_init+0x1b8/0x880 [marvell_nand])
[   14.299946] [<bf39e318>] (marvell_nand_chip_init [marvell_nand]) from [<bf39ecc0>] (marvell_nfc_probe+0x2e0/0x458 [marvell_nand])
[   14.310690] [<bf39ecc0>] (marvell_nfc_probe [marvell_nand]) from [<c0822770>] (platform_drv_probe+0x58/0xa8)
[   14.319745] [<c0822770>] (platform_drv_probe) from [<c08202f4>] (driver_probe_device+0x314/0x47c)
[   14.327918] [<c08202f4>] (driver_probe_device) from [<c0820568>] (__driver_attach+0x10c/0x134)
[   14.335862] [<c0820568>] (__driver_attach) from [<c081dc44>] (bus_for_each_dev+0x84/0xc4)
[   14.343398] [<c081dc44>] (bus_for_each_dev) from [<c081fa44>] (driver_attach+0x2c/0x30)
[   14.350772] [<c081fa44>] (driver_attach) from [<c081f2e8>] (bus_add_driver+0x168/0x268)
[   14.358146] [<c081f2e8>] (bus_add_driver) from [<c08212cc>] (driver_register+0x84/0x118)
[   14.365601] [<c08212cc>] (driver_register) from [<c08226c0>] (__platform_driver_register+0x50/0x58)
[   14.373943] [<c08226c0>] (__platform_driver_register) from [<bf3a5024>] (marvell_nfc_driver_init+0x24/0x1000 [marvell_nand])
[   14.384287] [<bf3a5024>] (marvell_nfc_driver_init [marvell_nand]) from [<c0303660>] (do_one_initcall+0x50/0x210)
[   14.393662] [<c0303660>] (do_one_initcall) from [<c0400cf8>] (do_init_module+0x74/0x224)
[   14.401118] [<c0400cf8>] (do_init_module) from [<c03ffbf0>] (load_module.constprop.17+0x20c0/0x280c)
[   14.409532] [<c03ffbf0>] (load_module.constprop.17) from [<c04005f0>] (sys_finit_module+0xc0/0x110)
[   14.417865] [<c04005f0>] (sys_finit_module) from [<c03011d8>] (__sys_trace_return+0x0/0x10)
[   14.425554] Exception stack(0xdd4c7fa8 to 0xdd4c7ff0)
[   14.430210] 7fa0:                   b6e4d728 0189f268 00000007 b6e4ce3c 00000000 b6e4d950
[   14.437744] 7fc0: b6e4d728 0189f268 413f7b00 0000017b 018ac100 00496b00 018abba8 00000000
[   14.445274] 7fe0: bef6b8a8 bef6b898 b6e46cf9 b6ef5ff2
[   14.449959] ---[ end trace 5e73e9525a320f70 ]---
[   14.454238] ------------[ cut here ]------------

and I see several of these during boot.

The commit identifies this warning as harmless but this isn't obvious
for users.

The Fixes-Line identifies 760c435e0f85 which is only in 4.19-rc1 but
it was backported to 4.18.9 so the problem appears there, too. Older
stable releases don't seem to include this commit.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K�nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Re: suggest 21a268069203 ("mtd: rawnand: marvell: prevent harmless warnings") for inclusion into 4.18.x

[Greg KH]

On Fri, Nov 30, 2018 at 08:12:47AM +0100, Uwe Kleine-K�nig wrote:
> Hello,
> 
> maybe it's already on your radar because the commit has a Fixes: line
> but to make sure you consider this: Commit
> 
> 	21a268069203 ("mtd: rawnand: marvell: prevent harmless warnings") 

4.18 is end-of-life, please see the front page of kernel.org as it shows
this properly.

So just move to 4.19.y, this fix is already in there :)

sorry,

greg k-h

Re: suggest 21a268069203 ("mtd: rawnand: marvell: prevent harmless warnings") for inclusion into 4.18.x

[Uwe Kleine-König]

Hello Greg,

On Fri, Nov 30, 2018 at 08:37:18AM +0100, Greg KH wrote:
> On Fri, Nov 30, 2018 at 08:12:47AM +0100, Uwe Kleine-K�nig wrote:
> > maybe it's already on your radar because the commit has a Fixes: line
> > but to make sure you consider this: Commit
> > 
> > 	21a268069203 ("mtd: rawnand: marvell: prevent harmless warnings") 
> 
> 4.18 is end-of-life, please see the front page of kernel.org as it shows
> this properly.
> 
> So just move to 4.19.y, this fix is already in there :)

I actually was proud that I checked I'm really on the newest 4.18.x and
also looked at the other stable branches if they are affected. It didn't
came to my mind that 4.18 was already EOL. Thanks for letting me know.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K�nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |