From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f193.google.com ([209.85.215.193]:39780 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726013AbeLANig (ORCPT ); Sat, 1 Dec 2018 08:38:36 -0500 Received: by mail-pg1-f193.google.com with SMTP id w6so3272811pgl.6 for ; Fri, 30 Nov 2018 18:27:14 -0800 (PST) Date: Fri, 30 Nov 2018 18:27:11 -0800 From: Brian Norris To: Ganapathi Bhat Cc: Kalle Valo , "linux-kernel@vger.kernel.org" , Amitkumar Karwar , Nishant Sarmukadam , Xinming Hu , "linux-wireless@vger.kernel.org" , "stable@vger.kernel.org" Subject: Re: [EXT] [4.20 PATCH] Revert "mwifiex: restructure rx_reorder_tbl_lock usage" Message-ID: <20181201022710.GA237752@google.com> References: <20181130175957.167031-1-briannorris@chromium.org> <2cbb1f04ef8545ad9eaf3d7551a5dc03@SC-EXCH02.marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2cbb1f04ef8545ad9eaf3d7551a5dc03@SC-EXCH02.marvell.com> Sender: stable-owner@vger.kernel.org List-ID: On Fri, Nov 30, 2018 at 07:04:49PM +0000, Ganapathi Bhat wrote: > > This was clearly not tested well at all. I simply performed 'wget' in a loop and > > it fell over within a few seconds. > Sorry. I had run a iperf test before sharing the patch (no regression observed). > It looks I failed to get this right for second time I will check this. Were you running on an 11n/ac network? IIUC, the particular code that's being blamed is only active with 11n+ features. You might also make sure you test with stuff like lockdep enabled, as that gives nice warnings and can even preemptively warn about potential problems before they even occur, if you use the right settings. (Some lockdep configurations can slow things down significantly, BTW.) Brian