From: Rafael David Tinoco <rafael.tinoco@linaro.org>
To: sashal@kernel.org
Cc: rafael.tinoco@linaro.org, gregkh@linuxfoundation.org,
rui.zhang@intel.com, edubezval@gmail.com,
daniel.lezcano@linaro.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: [PATCH 2/5] thermal/drivers/hisi: Remove pointless lock
Date: Mon, 3 Dec 2018 11:31:04 -0200 [thread overview]
Message-ID: <20181203133107.4002-3-rafael.tinoco@linaro.org> (raw)
In-Reply-To: <20181203133107.4002-1-rafael.tinoco@linaro.org>
From: Daniel Lezcano <daniel.lezcano@linaro.org>
commit 2d4fa7b4c6f8080ced2e8237c9f46fb1fc110d64 upstream.
The threaded interrupt inspect the sensors structure to look in the temp
threshold field, but this field is read-only in all the code, except in the
probe function before the threaded interrupt is set. In other words there
is not race window in the threaded interrupt when reading the field value.
Link: https://bugs.linaro.org/show_bug.cgi?id=4053 (PATCH 2/5)
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Reviewed-by: Leo Yan <leo.yan@linaro.org>
Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
(cherry picked from commit 2d4fa7b4c6f8080ced2e8237c9f46fb1fc110d64)
Signed-off-by: Rafael David Tinoco <rafael.tinoco@linaro.org>
---
drivers/thermal/hisi_thermal.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/thermal/hisi_thermal.c b/drivers/thermal/hisi_thermal.c
index aecbfe9fc8f2..0c2966c285b1 100644
--- a/drivers/thermal/hisi_thermal.c
+++ b/drivers/thermal/hisi_thermal.c
@@ -221,14 +221,10 @@ static irqreturn_t hisi_thermal_alarm_irq(int irq, void *dev)
static irqreturn_t hisi_thermal_alarm_irq_thread(int irq, void *dev)
{
struct hisi_thermal_data *data = dev;
- struct hisi_thermal_sensor *sensor;
-
- mutex_lock(&data->thermal_lock);
- sensor = &data->sensors;
+ struct hisi_thermal_sensor *sensor = &data->sensors;
dev_crit(&data->pdev->dev, "THERMAL ALARM: T > %d\n",
sensor->thres_temp);
- mutex_unlock(&data->thermal_lock);
thermal_zone_device_update(data->sensors.tzd,
THERMAL_EVENT_UNSPECIFIED);
--
2.20.0.rc1
next prev parent reply other threads:[~2018-12-03 13:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 13:31 v4.14 fix for Hikey 960 unbalanced IRQ enablement Rafael David Tinoco
2018-12-03 13:31 ` [PATCH 1/5] thermal/drivers/hisi: Remove the multiple sensors support Rafael David Tinoco
2018-12-03 13:31 ` Rafael David Tinoco [this message]
2018-12-03 13:31 ` [PATCH 3/5] thermal/drivers/hisi: Encapsulate register writes into helpers Rafael David Tinoco
2018-12-03 13:31 ` [PATCH 4/5] thermal/drivers/hisi: Fix configuration register setting Rafael David Tinoco
2018-12-03 13:31 ` [PATCH 5/5] thermal/drivers/hisi: Remove costly sensor inspection Rafael David Tinoco
2018-12-03 14:14 ` v4.14 fix for Hikey 960 unbalanced IRQ enablement Greg KH
2018-12-03 14:42 ` Daniel Lezcano
2018-12-03 15:19 ` Sasha Levin
2018-12-03 18:05 ` Greg KH
2018-12-03 18:24 ` Rafael David Tinoco
2018-12-06 11:05 ` Greg KH
2018-12-03 18:33 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181203133107.4002-3-rafael.tinoco@linaro.org \
--to=rafael.tinoco@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=edubezval@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox