From: Sasha Levin <sashal@kernel.org>
To: Ilya Dryomov <idryomov@gmail.com>
Cc: stable-commits@vger.kernel.org, stable@vger.kernel.org,
ben.hutchings@codethink.co.uk
Subject: Re: Patch "libceph: implement CEPHX_V2 calculation mode" has been added to the 4.14-stable tree
Date: Mon, 3 Dec 2018 10:26:02 -0500 [thread overview]
Message-ID: <20181203152602.GH235790@sasha-vm> (raw)
In-Reply-To: <CAOi1vP-2X7R4ru+A-pJEhnqnRECnfXkrjV1Z5Wh7L+FOZ3nUww@mail.gmail.com>
+ Ben
On Mon, Dec 03, 2018 at 12:09:25PM +0100, Ilya Dryomov wrote:
>On Sun, Dec 2, 2018 at 4:51 PM Sasha Levin <sashal@kernel.org> wrote:
>>
>> This is a note to let you know that I've just added the patch titled
>>
>> libceph: implement CEPHX_V2 calculation mode
>>
>> to the 4.14-stable tree which can be found at:
>> http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
>>
>> The filename of the patch is:
>> libceph-implement-cephx_v2-calculation-mode.patch
>> and it can be found in the queue-4.14 subdirectory.
>>
>> If you, or anyone else, feels it should not be added to the stable tree,
>> please let <stable@vger.kernel.org> know about it.
>>
>>
>>
>> commit 14735e0afb6ed378becd0dedf37d1e5ddfa12084
>> Author: Ilya Dryomov <idryomov@gmail.com>
>> Date: Fri Jul 27 19:25:32 2018 +0200
>>
>> libceph: implement CEPHX_V2 calculation mode
>>
>> commit cc255c76c70f7a87d97939621eae04b600d9f4a1 upstream.
>>
>> Derive the signature from the entire buffer (both AES cipher blocks)
>> instead of using just the first half of the first block, leaving out
>> data_crc entirely.
>>
>> This addresses CVE-2018-1129.
>>
>> Link: http://tracker.ceph.com/issues/24837
>> Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
>> Reviewed-by: Sage Weil <sage@redhat.com>
>> Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
>> Signed-off-by: Sasha Levin <sashal@kernel.org>
>
>Hi Sasha,
>
>The CVEs mentioned in this series are server side and CEPHX_V2 is
>probably more of a new feature than a security fix. That said, I don't
>object to including it in 4.14.z. If you do, please pick up the
>remaining two patches for interoperability:
>
>f1d10e046379 libceph: weaken sizeof check in ceph_x_verify_authorizer_reply()
>130f52f2b203 libceph: check authorizer reply/challenge length before reading
Would I be pulling this patch if it didn't have the string
"CVE-2018-1129" in the commit message?
--
Thanks,
Sasha
next prev parent reply other threads:[~2018-12-03 15:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181202155105.CA3F220851@mail.kernel.org>
2018-12-03 11:09 ` Patch "libceph: implement CEPHX_V2 calculation mode" has been added to the 4.14-stable tree Ilya Dryomov
2018-12-03 15:26 ` Sasha Levin [this message]
2018-12-03 15:32 ` Ilya Dryomov
2018-12-03 16:16 ` Sasha Levin
2018-12-05 22:25 ` Ben Hutchings
2018-12-06 5:45 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181203152602.GH235790@sasha-vm \
--to=sashal@kernel.org \
--cc=ben.hutchings@codethink.co.uk \
--cc=idryomov@gmail.com \
--cc=stable-commits@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox